1379460 - Search from Searchbar/LocationBar fails when press [Enter] key quickly twice if current tab is about:home

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P2)

Description

[Alice0775 White]

Reproducible: always if current tab is about:home

Steps To Reproduce:
1. Open about:home 
2. Type something in SearchBar
3. press [Enter] key quickly twice

Actual Results:
Location Bar shows without query word.
https://www.google.co.jp/webhp?ie=utf-8&oe=utf-8&client=firefox-b&gfe_rd=cr&ei=2vNhWcuvC8vEXtTJuKgN
So, Google top page shows without search results.

Expected Results:
Search results should be shown

Comment 1

[Alice0775 White]

The problem is
Pres [Enter] key moves focus to search field of about:home <--- this is BUG
And then 2nd [Enter] performs search with empty text of search field of about:home

Search from Locationbar also fails.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d00e4167b482&tochange=94bdba42b846
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=bcb1945e390e&tochange=0c812727c95a

Regressed by: Bug 1171344

Comment 3

[Alice0775 White]

(BTW, Pressing [Enter] twice for IME user's muscle memory)

Comment 4

[Florian Quèze [:florian]]

I guess we should wait until something has loaded in the content area before moving the focus from the search (or location) bar to the content area.

Comment 5

[Florian Quèze [:florian]]

The focus seems to be moved by the code at http://searchfox.org/mozilla-central/rev/4aaa08513911c3cfe750611a6c087b438bb1f88e/browser/base/content/utilityOverlay.js#488

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

I can no longer reproduce this, so I am going to resolve the bug. Please reopen if you can reproduce in the latest Nightly with similar steps.