1379575 - [Form Autofill] Make Phishing Warning consistent no matter hovering on items or not.

Status: RESOLVED FIXED

(Toolkit :: Form Manager, defect, P3)

Description

[Sean Lee [:seanlee][:weilonge]]

Attachment: Inconsistent Phishing Warning

Phishing warning is changed after hovering on a profile item.
When focusing on address-level2 field, the phishing warning shows "Also fill company, address, phone, email".

Then hovering on any item, it shows "Also fill company, phone, email" (without "address").

There should be no difference of wanring message when hovering items or not.

Comment 1

[Matthew N. [:MattN]]

Yeah, I agree we should be consistent about whether "address" is shown in that case.

Comment 2

[Ray Lin[:ralin]]

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #1)
> Yeah, I agree we should be consistent about whether "address" is shown in
> that case.

I'd prefer not to show "address" since it has already focused on ddress-level2 in this case. So, both case(selected or non-selected) would show the same string: "Also fill company, phone, email"

MattN, do you think it's fine to do that to minimize the chance of height changing?

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Hey Ray,

(In reply to Ray Lin[:ralin] from comment #2)
> I'd prefer not to show "address" since it has already focused on
> ddress-level2 in this case. So, both case(selected or non-selected) would
> show the same string: "Also fill company, phone, email"

After discussing with Juwei, she thinks that the warning message should not contain the focused type and be consistent.
Another issue is about the order of the field type in Warning Message.
Please follow the item 3 in the spec[1] to design the message. Thanks.

[1] https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/185446489

Comment 4

[Ray Lin[:ralin]]

Attachment: Bug 1379575 - Do not show focused category in autofill notes if none of the profiles have been selected.

Review commit: https://reviewboard.mozilla.org/r/156496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156496/

Comment 5

[Ray Lin[:ralin]]

(In reply to Sean Lee [:seanlee][:weilonge] from comment #3)
> Hey Ray,
> 
> (In reply to Ray Lin[:ralin] from comment #2)
> > I'd prefer not to show "address" since it has already focused on
> > ddress-level2 in this case. So, both case(selected or non-selected) would
> > show the same string: "Also fill company, phone, email"
> 
> After discussing with Juwei, she thinks that the warning message should not
> contain the focused type and be consistent.
> Another issue is about the order of the field type in Warning Message.
> Please follow the item 3 in the spec[1] to design the message. Thanks.
> 
> [1] https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/185446489

I've addressed that problem in the patch, thanks for the information.

Comment 6

[Matthew N. [:MattN]]

Comment on attachment 8885641 [details]
Bug 1379575 - Do not show focused category in autofill notes if none of the profiles have been selected.

https://reviewboard.mozilla.org/r/156496/#review161678

Comment 7

[Ray Lin[:ralin]]

Thank you Matt


try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c733ba3176a512acfe41a65e9a8e1ebbe8cf6bb

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f07c253160b
Do not show focused category in autofill notes if none of the profiles have been selected. r=MattN

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8f07c253160b