1379584 - Undo menu broken when deleting text with keyboard in a content editable zone.

Status: ASSIGNED

(Web Compatibility :: Site Reports, defect, P5)

Description

[Rémy Hubscher (:natim)]

Removing a text with the Delete key in a content editable zone and then trying to Undo with the right click menu doesn't work.

[Step to reproduce]
1. Access https://quilljs.com/playground/
2. Type some text inside
3. Select and remove with your keyboard (either Delete or Backspace)
4. Right click and select the Undo menu.

[Expected behavior]

The deleted text is back on the text area

[Actual behavior]

The Undo menu has no action.

Refs https://github.com/mozilla/notes/issues/114

Comment 1

[:Gijs (he/him)]

Did this use to work (ie is this a regression) ?

Comment 2

[Rémy Hubscher (:natim)]

I have no idea, it appears to work fine in a textarea though.

Refs: https://github.com/mozilla/notes/issues/114

Comment 3

[Alice0775 White]

FYI,
UA spoofing seems to fix the problem on Windows10 Nightly56.0a1.
i.e, seting general.useragent.override = "Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36"

Comment 4

[Makoto Kato [:m_kato]]

Great thanks, Alice-san.

At least, since this doesn't work on Firefox 54, I don't think that this is recently regression.  We might have to investigate this why this doesn't work.

Comment 5

[Alice0775 White]

Error in Browser console:
IndexSizeError: Component returned failure code: 0x80530001 [nsIDocShell.doCommand]  browser-child.js:401

Comment 6

[Makoto Kato [:m_kato]]

This is site issue.  This editor manages undo transaction by self, not Gecko.  So when using [Ctrl] + [Z], it is handled by javascript, not our transaction manager.

But context menu uses Gecko's transaction manager.  So it doesn't work. (since delete selection isn't into undo stack)

contenteditable cannot turn off undo stack from javascript, if https://github.com/w3c/editing/issues/150 is resolved, undo menu can be turned off.

Comment 7

[Makoto Kato [:m_kato]]

This is site bug and there is no spec to turn off undo stack of browser.

If delete selection (step. 3) is handled by browser, undo will work.  But step. 3 is handled by site's JS unfortunately.  So this operation isn't added into our undo stack.

Comment 8

[Firefox Bug Husbandry Bot]

See bug 1547409. Moving webcompat whiteboard tags to keywords.

Comment 9

[Raul Bucata]

I was able to reproduce the issue. The undo menu option does not work:

https://media.giphy.com/media/mXJsMdfvHnGuR02SKb/giphy.gif

Tested with:

Browser / Version: Firefox Nightly 100.0a1 (2022-03-28) (64-bit) / Chrome Version 99.0.4844.84 (Official Build) (64-bit)
Operating System: Windows 10 PRO x64

Comment 10

[Raul Bucata]

The issue is still reproducible.

Tested with:

Browser / Version: Firefox Nightly 110.0a1 (2023-01-12) (64-bit)
Operating System: Windows 10 PRO x64

Notes:

1. Reproducible regardless of the status of ETP.
2. Reproducible on the latest build of Firefox Nightly and Release.
3. Works as expected using Chrome (the whole text is deleted).

Moving this to NeedsDiagnosis for further investigations.