1379604 - Update webrender to 479ae6475a18527206a2534c2b8a5bfb8b06bd6e

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1374730 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ d7d482bc49d2af8394a4dbe142d2cf65e9629874

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d9689595733e9ec9e3ff235c5ed183db0e3b1fca
https://treeherder.mozilla.org/#/jobs?repo=try&revision=84df4791fdb4e407ce75fd3be3fd8a25163cbe28

Back to having an R7 failure. Regression range:

*   d7d482b Auto merge of #1457 - glennw:hinting, r=kvark
|\
| * 86c4e37 Make the selection of pt size in Freetype exactly match the gecko code.
| * ff4ba8b Use light hinting for Linux glyphs. This is a better default and matches glyphs exactly as Gecko draws them by default.
* 7367c0d Auto merge of #1464 - staktrace:neested, r=kvark
* 67c5f41 Fix typo in identifier name

Comment 2

[Kartikaya Gupta (email:[e-mail])]

servo/webrender#1457 caused a reftest failure in layout/reftests/stylesheet-cloning/counter-style-rule-clone.html - which is the same one that #1441 caused to fail (bug 1374730 comment 26). The reftest analyzer [1] shows visible differences, although the changes look better than what happened in #1441 (i.e. the text is evenly "thicker" as opposed to be thicker at the top and thin on the bottom). The test is already marked fuzzy for webrender but the fuzz is not enough to cover the new failure. I'm not sure if the change in behaviour is expected - if so we can increase the fuzz to cover the new difference.

[1] https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/ToVN4to6QuyowIZBlD68RA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ d7d482bc49d2af8394a4dbe142d2cf65e9629874

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d80b2b329e84fc11ea29fe014818ae4645ad5093
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ea0f195689759c90fceec089257256d1b8bb46a

WR @ b516cbca1319cc4b3a69405fd3ec5884a7ae0939

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9eb2eb1083695aeb5e8c2394c1e9ec97e81f7363
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b328bc3c4f6439dbbe6eef4b495e157b6fdcbab

Same as before, R7 failure only.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 33e6e285553e8f5ab4b17f3ff8f4eeecd76d2264

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5f1d06a322f8c973d7794105687bb080a94c036
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b13ae062898b90d82fe55dc811cd671d5203071

Same as before.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 479ae6475a18527206a2534c2b8a5bfb8b06bd6e

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7c8d25942b10e7b9ba0da6242882543469cbf1d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d6442efc0a7439c81037a2f247c315ba235e1a9

Bustage

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: counter-style-rule-clone before/after screenshots

For posterity, this is what the reftest analyzer showed before and after servo/webrender#1457 changed the behaviour. After the PR, the "image" text got noticeably even thicker than the "reference" text, even though it was already thicker before.

This necessitates increasing the fuzz values to cover the difference.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

WR @ 479ae6475a18527206a2534c2b8a5bfb8b06bd6e with bustage fixed, and the reftest fuzz increased:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e42fe24cee981359396fdd0f141f933b43181897
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e2157eaf7deae080f37ccc8d0d77575a44d94c1

Green (so far)

I'll get the patches up for review since glandium wants to pick up servo/webrender#1475.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1379604 - Update webrender to cset 479ae6475a18527206a2534c2b8a5bfb8b06bd6e.

Review commit: https://reviewboard.mozilla.org/r/156992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156992/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1379604 - Update versions in Cargo.toml/Cargo.lock files.

Review commit: https://reviewboard.mozilla.org/r/156994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156994/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1379604 - Update fuzz values on counter-style-rule-clone from WR cset ff4ba8b.

Review commit: https://reviewboard.mozilla.org/r/156996/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156996/

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1379604 - Update webrender_bindings for API change in WR cset d97598b.

Review commit: https://reviewboard.mozilla.org/r/156998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156998/

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1379604 - Update webrender_bindings for API change in WR cset 6824b35.

Review commit: https://reviewboard.mozilla.org/r/157000/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157000/

Comment 13

[Martin Robinson (email:[e-mail])]

Comment on attachment 8886192 [details]
Bug 1379604 - Update webrender_bindings for API change in WR cset 6824b35.

https://reviewboard.mozilla.org/r/157000/#review162062

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8886188 [details]
Bug 1379604 - Update webrender to cset 479ae6475a18527206a2534c2b8a5bfb8b06bd6e.

https://reviewboard.mozilla.org/r/156992/#review162180

Comment 15

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8886189 [details]
Bug 1379604 - Update versions in Cargo.toml/Cargo.lock files.

https://reviewboard.mozilla.org/r/156994/#review162182

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8886190 [details]
Bug 1379604 - Update fuzz values on counter-style-rule-clone from WR cset ff4ba8b.

https://reviewboard.mozilla.org/r/156996/#review162186

Comment 17

[Aria Beingessner [:Gankra]]

Comment on attachment 8886191 [details]
Bug 1379604 - Update webrender_bindings for API change in WR cset d97598b.

https://reviewboard.mozilla.org/r/156998/#review162196

There's some new APIs that can also be exposed, but I'll handle that in my PR.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e41daf74637e
Update webrender to cset 479ae6475a18527206a2534c2b8a5bfb8b06bd6e. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/62e217f1fec0
Update versions in Cargo.toml/Cargo.lock files. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/6518b2aec9de
Update fuzz values on counter-style-rule-clone from WR cset ff4ba8b. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f02a30a0292b
Update webrender_bindings for API change in WR cset d97598b. r=Gankro
https://hg.mozilla.org/integration/autoland/rev/5eb20b6ab3ad
Update webrender_bindings for API change in WR cset 6824b35. r=mrobinson

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e41daf74637e
https://hg.mozilla.org/mozilla-central/rev/62e217f1fec0
https://hg.mozilla.org/mozilla-central/rev/6518b2aec9de
https://hg.mozilla.org/mozilla-central/rev/f02a30a0292b
https://hg.mozilla.org/mozilla-central/rev/5eb20b6ab3ad