Closed Bug 1379757 Opened 7 years ago Closed 7 years ago

stylo: panic in style::properties::animated_properties::{{impl}}::add_weighted

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: rillian, Assigned: hiro)

References

(Blocks 1 open bug,
URL
)

Details

Crash Data

Attachments

(1 file)

Bug 1379757 - Consider f64 epsilon for add_weighted portions.
59 bytes, text/x-review-board-request
birtles
: review+
Details
URL: https://ultimaker.com/en/products/cur...
Has STR: --- → yes
Version: unspecified → Trunk
Crash Signature: [@ mozalloc_abort | abort | style::properties::animated_properties::{{impl}}::add_weighted ]
This is a precision issue.

The panic at;
https://hg.mozilla.org/mozilla-central/file/5d794bf4c465/servo/components/style/properties/helpers/animated_properties.mako.rs#l2275

self_portion=1.0554608982645259, other_portion=-0.055460898264526041
When we fix this, we should really convert that to a debug_assert too.
Yeah, I am on it.
Comment on attachment 8885016 [details]
Bug 1379757 - Consider f64 epsilon for add_weighted portions.

https://reviewboard.mozilla.org/r/155846/#review161008

Thank you!
Attachment #8885016 - Flags: review?(bbirtles) → review+
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/f323fe1f0d48
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Verified fixed in Nightly 56 x64 20170712100301 @ Debian Testing (Linux 4.11.0-1-amd64, Radeon RX480):
Tab does not crash anymore on https://ultimaker.com/en/products/cura-software
Assignee: nobody → hikezoe
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: