Closed
Bug 1379757
Opened 8 years ago
Closed 8 years ago
stylo: panic in style::properties::animated_properties::{{impl}}::add_weighted
Categories
(Core :: CSS Parsing and Computation, defect, P1)
Core
CSS Parsing and Computation
Tracking
()
VERIFIED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: rillian, Assigned: hiro)
References
(Blocks 1 open bug, )
Details
Crash Data
Attachments
(1 file)
Visiting https://ultimaker.com/en/products/cura-software crashes my nightly build with stylo enabled. See https://crash-stats.mozilla.com/report/index/6b7d1d78-8418-47ef-bee9-f49c20170710
|
||
Updated•8 years ago
|
|
|
||
Updated•8 years ago
|
Crash Signature: [@ mozalloc_abort | abort | style::properties::animated_properties::{{impl}}::add_weighted ]
|
Assignee | |
Comment 1•8 years ago
|
||
This is a precision issue.
The panic at;
https://hg.mozilla.org/mozilla-central/file/5d794bf4c465/servo/components/style/properties/helpers/animated_properties.mako.rs#l2275
self_portion=1.0554608982645259, other_portion=-0.055460898264526041
|
||
Comment 2•8 years ago
|
||
When we fix this, we should really convert that to a debug_assert too.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Yeah, I am on it.
| Comment hidden (mozreview-request) |
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885016 [details]
Bug 1379757 - Consider f64 epsilon for add_weighted portions.
https://reviewboard.mozilla.org/r/155846/#review161008
Thank you!
Attachment #8885016 -
Flags: review?(bbirtles) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
|
||
Updated•8 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 7•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
|
||
Comment 8•8 years ago
|
||
Verified fixed in Nightly 56 x64 20170712100301 @ Debian Testing (Linux 4.11.0-1-amd64, Radeon RX480):
Tab does not crash anymore on https://ultimaker.com/en/products/cura-software
Assignee: nobody → hikezoe
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•