Closed
Bug 1379788
Opened 7 years ago
Closed 7 years ago
Stop loading RecentWindow.jsm during startup
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
Details
Attachments
(1 file)
|
4.81 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
My local testing shows that it's currently being imported during startup by: - browser/base/content/utilityOverlay.js - it's an accident, should be a lazy getter. - browser/modules/BrowserUITelemetry.jsm - this code gets the most recent window but then waits for the search service to init... and that window can have been closed during that time. I think it makes more sense to get that window once the search service init is finished. - browser/modules/ExtensionsUI.jsm - it's used only to know when startup is done; I don't think the slight Services.wm.getMostRecentWindow brokenness on Linux will have any impact.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8884994 -
Flags: review?(mconley)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8884994 [details] [diff] [review] Patch Review of attachment 8884994 [details] [diff] [review]: ----------------------------------------------------------------- Stealing, lgtm! :-)
Attachment #8884994 -
Flags: review?(mconley) → review+
Pushed by florian@queze.net: https://hg.mozilla.org/integration/mozilla-inbound/rev/1fcc2c629f1b Stop loading RecentWindow.jsm during startup, r=Gijs.
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1fcc2c629f1b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•