Stop loading RecentWindow.jsm during startup

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
My local testing shows that it's currently being imported during startup by:

- browser/base/content/utilityOverlay.js - it's an accident, should be a lazy getter.

- browser/modules/BrowserUITelemetry.jsm - this code gets the most recent window but then waits for the search service to init... and that window can have been closed during that time. I think it makes more sense to get that window once the search service init is finished.

- browser/modules/ExtensionsUI.jsm - it's used only to know when startup is done; I don't think the slight Services.wm.getMostRecentWindow brokenness on Linux will have any impact.
(Assignee)

Comment 1

2 years ago
Posted patch PatchSplinter Review
Attachment #8884994 - Flags: review?(mconley)

Comment 2

2 years ago
Comment on attachment 8884994 [details] [diff] [review]
Patch

Review of attachment 8884994 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing, lgtm! :-)
Attachment #8884994 - Flags: review?(mconley) → review+

Comment 3

2 years ago
Pushed by florian@queze.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fcc2c629f1b
Stop loading RecentWindow.jsm during startup, r=Gijs.

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1fcc2c629f1b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.