1379813 - Annotate crash reports with the GPU process generation number

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

We currently annotate crash reports with whether or not the GPU process is currently running [1]. Milan suggested we add a new annotation with the number of times the GPU process has been launched (available in mNumProcessAttempts). "GPUProcessLaunchCount" might be a reasonable key name.

This will help us see if crashes are more likely after a relaunch than an initial launch.

[1] http://searchfox.org/mozilla-central/source/gfx/ipc/GPUProcessManager.cpp#366

Comment 1

[Dominic Farolino [:domfarolino]]

Attachment: bug1379813.patch

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8885947 [details] [diff] [review]
bug1379813.patch

Review of attachment 8885947 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUProcessManager.cpp
@@ +365,5 @@
>    CrashReporter::AnnotateCrashReport(
>      NS_LITERAL_CSTRING("GPUProcessStatus"),
>      NS_LITERAL_CSTRING("Running"));
> +
> +CrashReporter::AnnotateCrashReport(

nit: two-space indent, use "%d" (more idiomatic in gecko)

@@ +661,5 @@
>    CrashReporter::AnnotateCrashReport(
>      NS_LITERAL_CSTRING("GPUProcessStatus"),
>      NS_LITERAL_CSTRING("Destroyed"));
> +
> +CrashReporter::AnnotateCrashReport(

Just the first annotation is enough. The count only changes on launch.

Comment 3

[Dominic Farolino [:domfarolino]]

Attachment: bug1379813.patch

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8886279 [details] [diff] [review]
bug1379813.patch

Review of attachment 8886279 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUProcessManager.cpp
@@ +367,5 @@
>    CrashReporter::AnnotateCrashReport(
>      NS_LITERAL_CSTRING("GPUProcessStatus"),
>      NS_LITERAL_CSTRING("Running"));
> +
> +CrashReporter::AnnotateCrashReport(

Indentation is still off here.

Comment 5

[Dominic Farolino [:domfarolino]]

Attachment: bug1379813.patch

Whoops, forgot to address your other two nits!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35beba17c550
Annotate crash reports with the number of times the GPU process has been launched. r=dvander

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35beba17c550