Annotate crash reports with the GPU process generation number

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dvander, Assigned: domfarolino)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

We currently annotate crash reports with whether or not the GPU process is currently running [1]. Milan suggested we add a new annotation with the number of times the GPU process has been launched (available in mNumProcessAttempts). "GPUProcessLaunchCount" might be a reasonable key name.

This will help us see if crashes are more likely after a relaunch than an initial launch.

[1] http://searchfox.org/mozilla-central/source/gfx/ipc/GPUProcessManager.cpp#366
Comment on attachment 8885947 [details] [diff] [review]
bug1379813.patch

Review of attachment 8885947 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUProcessManager.cpp
@@ +365,5 @@
>    CrashReporter::AnnotateCrashReport(
>      NS_LITERAL_CSTRING("GPUProcessStatus"),
>      NS_LITERAL_CSTRING("Running"));
> +
> +CrashReporter::AnnotateCrashReport(

nit: two-space indent, use "%d" (more idiomatic in gecko)

@@ +661,5 @@
>    CrashReporter::AnnotateCrashReport(
>      NS_LITERAL_CSTRING("GPUProcessStatus"),
>      NS_LITERAL_CSTRING("Destroyed"));
> +
> +CrashReporter::AnnotateCrashReport(

Just the first annotation is enough. The count only changes on launch.
Attachment #8885947 - Flags: review?(dvander)
(Assignee)

Comment 3

a year ago
Created attachment 8886279 [details] [diff] [review]
bug1379813.patch
Attachment #8885947 - Attachment is obsolete: true
Attachment #8886279 - Flags: review?(dvander)
Comment on attachment 8886279 [details] [diff] [review]
bug1379813.patch

Review of attachment 8886279 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/ipc/GPUProcessManager.cpp
@@ +367,5 @@
>    CrashReporter::AnnotateCrashReport(
>      NS_LITERAL_CSTRING("GPUProcessStatus"),
>      NS_LITERAL_CSTRING("Running"));
> +
> +CrashReporter::AnnotateCrashReport(

Indentation is still off here.
Attachment #8886279 - Flags: review?(dvander)
(Assignee)

Comment 5

a year ago
Created attachment 8886344 [details] [diff] [review]
bug1379813.patch

Whoops, forgot to address your other two nits!
Attachment #8886279 - Attachment is obsolete: true
Attachment #8886344 - Flags: review?(dvander)
Attachment #8886344 - Flags: review?(dvander) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35beba17c550
Annotate crash reports with the number of times the GPU process has been launched. r=dvander
Keywords: checkin-needed

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/35beba17c550
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.