1379835 - elfhack build failure on Android

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

For $reasons, elfhack ends up disabled on Android, and when working around that to enable it, it fails to build with:

[task 2017-07-07T01:40:29.426034Z] 01:40:29     INFO -  In file included from /home/worker/workspace/build/src/obj-firefox/build/unix/elfhack/inject/arm.c:5:0:
[task 2017-07-07T01:40:29.426164Z] 01:40:29     INFO -  /home/worker/workspace/build/src/android-ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/lib/gcc/arm-linux-androideabi/4.9/include/stdint.h:9:26: fatal error: stdint.h: No such file or directory
[task 2017-07-07T01:40:29.426203Z] 01:40:29     INFO -   # include_next <stdint.h>
[task 2017-07-07T01:40:29.426238Z] 01:40:29     INFO -                            ^
[task 2017-07-07T01:40:29.426273Z] 01:40:29     INFO -  compilation terminated.
[task 2017-07-07T01:40:29.426330Z] 01:40:29     INFO -  /home/worker/workspace/build/src/config/rules.mk:793: recipe for target 'arm.o' failed
[task 2017-07-07T01:40:29.426368Z] 01:40:29     INFO -  gmake[5]: *** [arm.o] Error 1

The problem is the missing -idirafter flag on the build command line.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1379835 - Don't filter out -idirafter flag when building elfhack injected code.

Review commit: https://reviewboard.mozilla.org/r/155884/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155884/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8885042 [details]
Bug 1379835 - Don't filter out -idirafter flag when building elfhack injected code.

https://reviewboard.mozilla.org/r/155884/#review161798

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b93743bba953
Don't filter out -idirafter flag when building elfhack injected code. r=gps

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b93743bba953