1379865 - stylo: don't perform parent display-based style fixups on pseudos except ::before/::after

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Comment 1

[Cameron McCormack (:heycam)]

I'll rebase my patches from bug 1376406 on top of bug 1379505 once that's landed.

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7172a54f5db9cb2cf929ab452b14623a27571ba7

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1379865 - style: Don't perform parent display-based style fixups on most pseudos.

Review commit: https://reviewboard.mozilla.org/r/157710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157710/

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8886947 [details]
Bug 1379865 - style: Don't perform parent display-based style fixups on most pseudos.

https://reviewboard.mozilla.org/r/157710/#review163402

Comment 5

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s fe4ad2854028 -d 070e735031cc: rebasing 411541:fe4ad2854028 "Bug 1379865 - style: Don't perform parent display-based style fixups on most pseudos. r=emilio" (tip)
merging servo/components/style/gecko/pseudo_element.rs
merging servo/components/style/servo/selector_parser.rs
merging servo/components/style/style_resolver.rs
warning: conflicts while merging servo/components/style/servo/selector_parser.rs! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8886947 [details]
Bug 1379865 - style: Don't perform parent display-based style fixups on most pseudos.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157710/diff/1-2/

Comment 7

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa6b29364464422e3dfce624997dc764564abd98&group_state=expanded

Comment 8

[Mozilla Autoland]

hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files
remote: (9dd50b7f0680 modifies servo/components/style/gecko/pseudo_element.rs from Servo; not enforcing peer review)
remote: (9dd50b7f0680 modifies servo/components/style/servo/selector_parser.rs from Servo; not enforcing peer review)
remote: (9dd50b7f0680 modifies servo/components/style/style_resolver.rs from Servo; not enforcing peer review)
remote: (1 changesets contain changes to protected servo/ directory: 9dd50b7f0680)
remote: ************************************************************************
remote: you do not have permissions to modify files under servo/
remote: 
remote: the servo/ directory is kept in sync with the canonical upstream
remote: repository at https://github.com/servo/servo
remote: 
remote: changes to servo/ are only allowed by the syncing tool and by sheriffs
remote: performing cross-repository "merges"
remote: 
remote: to make changes to servo/, submit a Pull Request against the servo/servo
remote: GitHub project
remote: ************************************************************************
remote: transaction abort!
remote: rollback completed
remote: pretxnchangegroup.e_prevent_vendored hook failed
abort: push failed on remote

Comment 9

[Cameron McCormack (:heycam)]

Merged.