Closed
Bug 1379868
Opened 8 years ago
Closed 8 years ago
Disable Mochitest-gl under Windows 32-bit non-e10s mode.
Categories
(Core :: Graphics: CanvasWebGL, enhancement)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: cleu, Assigned: jmaher)
References
Details
Attachments
(3 files)
|
2.72 KB,
patch
|
mozilla
:
review+
|
Details | Diff | Splinter Review |
|
4.39 KB,
text/plain
|
Details | |
|
491 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
There are many intermittent mochitest-gl failures which are related to OOM and they are all present under windows 32-bit non-e10s mode only.
Since those failures are caused by architectural limitation and non-e10s mochitests will be disabled by default after 57 is released, it should be OK to disable mochitest-gl under windows 32-bit non-e10s mode.
It will be beneficial for our mochitest stability.
Comment 1•8 years ago
|
||
That sounds fine.
| Reporter | ||
Comment 2•8 years ago
|
||
Hi Joel,
According to discussion in bug 1298285, we are considering disabling mochitest-gl under win32 non-e10s mode.
I have discussed with :jgilbert and the conclusion is positive.
So I think we can disable it.
It should reduce many intermittent failures in mochitest-gl.
Flags: needinfo?(jmaher)
| Assignee | ||
Comment 3•8 years ago
|
||
this is great, do you want this for all branches or on nightly/trunk and let it ride the trains?
Flags: needinfo?(jmaher)
| Assignee | ||
Comment 4•8 years ago
|
||
| Assignee | ||
Comment 5•8 years ago
|
||
| Assignee | ||
Updated•8 years ago
|
Attachment #8886239 -
Flags: review?(catlee) → review?(aki)
Updated•8 years ago
|
Attachment #8886239 -
Flags: review?(aki) → review+
| Assignee | ||
Comment 6•8 years ago
|
||
landed on buildbot-configs:
https://hg.mozilla.org/build/buildbot-configs/rev/1062b83fe037b64c589793096ffb4c3bc1eee343
Comment 7•8 years ago
|
||
Merged to prod - https://hg.mozilla.org/build/buildbot-configs/rev/8b4445eb311e.
| Assignee | ||
Comment 8•8 years ago
|
||
this is deployed and for win7 we are not running webgl on non-e10s, we still are for win8.
Comment 9•8 years ago
|
||
tc jobs are still running; this should take care of that.
Attachment #8886628 -
Flags: review?(jmaher)
| Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8886628 [details] [diff] [review]
stop running taskcluster windows 7 non-e10s
Review of attachment 8886628 [details] [diff] [review]:
-----------------------------------------------------------------
great, nice and simple.
Attachment #8886628 -
Flags: review?(jmaher) → review+
Comment 11•8 years ago
|
||
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/94fbfcd285f5
Stop running mochitest-gl on tc Windows 7 non-e10s; r=jmaher
Comment 12•8 years ago
|
||
Can we do this for DevEdition builds as well? At least on Beta, they're still running and failing.
| Reporter | ||
Comment 13•8 years ago
|
||
I think it should be fine to do this on other branches as well.
Comment 14•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•