Closed Bug 1379891 Opened 3 years ago Closed 2 years ago

Remove nsPIEditorTransaction

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: m_kato, Assigned: adrian17)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is comment of this interface.

 * This interface is implemented by every transaction created by this
 * editor implementation. It is used to help us distinguish our internal
 * transactions from those generated by 3rd party extensions.

So after we don't support 3rd party XPCOM extension, we can remove this.
Comment on attachment 8941583 [details]
Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods.

Reviewboard causes internal error to modify flags and add reviewer...

I look OK.  Nakano-san, do you have any objections to remove this?

nsPIEditorTransaction uses to detect current ITransaction is editor's transaction.  Although nsITransaction interface uses places database too, since we cannot use  XPCOM from Firefox extension, I think that we can remove this interface.  Although Thunderbird can still use this interface from extension...
Attachment #8941583 - Flags: review?(masayuki)
Attachment #8941583 - Flags: review?(m_kato)
Attachment #8941583 - Flags: review+
Comment on attachment 8941583 [details]
Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods.

Looks like that you forgot to do |hg remove editor/nsPIEditorTransaction.idl|. Please remove the file and merge it to this commit before landing.
Attachment #8941583 - Flags: review?(masayuki) → review+
> Although nsITransaction interface uses places database too, since we cannot use  XPCOM from Firefox extension,
> I think that we can remove this interface.

Yes, and if we make Places not use nsITransaction, we could remove the interface. However, I don't think that it's worthwhile at least for now.

> Although Thunderbird can still use this interface from extension...

Do you mean some addons for Thunderbird still use nsPIEditorTransaction? But I think that they can just stop using it since any addons shouldn't create its own transaction and insert it to transaction manger of editor.
(Although dxr for addon doesn't work since yesterday. So, I haven't checked how they use nsPIEditorTransaction actually yet.)
Looks like there is one use of txnDescription getter in comm-central, in debugQA extension:

https://searchfox.org/comm-central/source/suite/extensions/debugQA/content/debugQAEditorOverlay.js#412

Should the getter be moved to nsITransaction to keep it working, or deal with it the other way?
No. We've already ignored the QA addon when we change some API. Looks like that SeaMonkey isn't active project and its extensions isn't necessary for users.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a50f8a3e3701
remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki
Helped Adrian land the patch since he told me that MozReview got confused.
https://hg.mozilla.org/mozilla-central/rev/a50f8a3e3701
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Comment on attachment 8941583 [details]
Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods.

Although this is already landed with r+...
Attachment #8941583 - Flags: review?(m_kato) → review+
Assignee: nobody → adrian.wielgosik
You need to log in before you can comment on or make changes to this bug.