1379896 - Photon reload animation is causing a lot of intermittent inconsistencies

Status: VERIFIED FIXED

(Testing :: mozscreenshots, enhancement, P1)

Description

[Johann Hofmann [:johannh]]

Example: https://screenshots.mattn.ca/comparisons/mozilla-central/5d794bf4c4653153e602631f1b8818acd559d8f5/mozilla-central/0e41d07a703f19224f60b01577b2cbb5708046c9/linux64/controlCenter_17_noLWT_httpPassword.png

I'd suggest we just disable all cosmetic animations via pref to solve this.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1379896 - Disable cosmetic animations in mozscreenshots.

Review commit: https://reviewboard.mozilla.org/r/156002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156002/

Comment 2

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=045bf5ea03fd8b10c1d5cb05abe3aee871b0f1e4

Comment 3

[Matthew N. [:MattN] (PM me if requests are blocking you)]

Comment on attachment 8885142 [details]
Bug 1379896 - Disable cosmetic animations in mozscreenshots.

https://reviewboard.mozilla.org/r/156002/#review162302

I guess this is okay for the short term to get rid of intermittents but it means we're not really testing what we ship by default which seems counterproductive for this tool…

Thoughts?

Comment 4

[Johann Hofmann [:johannh]]

(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #3)
> Comment on attachment 8885142 [details]
> Bug 1379896 - Disable cosmetic animations in mozscreenshots.
> 
> https://reviewboard.mozilla.org/r/156002/#review162302
> 
> I guess this is okay for the short term to get rid of intermittents but it
> means we're not really testing what we ship by default which seems
> counterproductive for this tool…
> 
> Thoughts?

Yes, I have the same concern. I think it's a compromise we have to make at this point, but it's good that we're asking this question whenever we flip a pref. We should reconsider a better solution if we find that this prevents us from catching a number of issues.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d0e153fe492
Disable cosmetic animations in mozscreenshots. r=MattN

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d0e153fe492

Comment 7

[Stefan [:StefanG_QA]]

This issue is verified with Nightly build from 2017-07-14 (20170714030205) and with Latest Nightly (20171003100226) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.