Closed Bug 1379896 Opened 2 years ago Closed 2 years ago

Photon reload animation is causing a lot of intermittent inconsistencies

Categories

(Testing :: mozscreenshots, enhancement, P1)

Version 3
enhancement

Tracking

(firefox56 verified)

VERIFIED FIXED
mozilla56
Iteration:
56.3 - Jul 24
Tracking Status
firefox56 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(1 file)

Whiteboard: [reserve-photon-animation]
Comment on attachment 8885142 [details]
Bug 1379896 - Disable cosmetic animations in mozscreenshots.

https://reviewboard.mozilla.org/r/156002/#review162302

I guess this is okay for the short term to get rid of intermittents but it means we're not really testing what we ship by default which seems counterproductive for this tool…

Thoughts?
Attachment #8885142 - Flags: review?(MattN+bmo) → review+
(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #3)
> Comment on attachment 8885142 [details]
> Bug 1379896 - Disable cosmetic animations in mozscreenshots.
> 
> https://reviewboard.mozilla.org/r/156002/#review162302
> 
> I guess this is okay for the short term to get rid of intermittents but it
> means we're not really testing what we ship by default which seems
> counterproductive for this tool…
> 
> Thoughts?

Yes, I have the same concern. I think it's a compromise we have to make at this point, but it's good that we're asking this question whenever we flip a pref. We should reconsider a better solution if we find that this prevents us from catching a number of issues.
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d0e153fe492
Disable cosmetic animations in mozscreenshots. r=MattN
https://hg.mozilla.org/mozilla-central/rev/8d0e153fe492
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Iteration: --- → 56.3 - Jul 24
This issue is verified with Nightly build from 2017-07-14 (20170714030205) and with Latest Nightly (20171003100226) on Windows 10 x64, Ubuntu 16.04 x64 and Mac OS X 10.12.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.