Closed
Bug 1379899
Opened 9 years ago
Closed 8 years ago
test_browserElement_oop_ExposableURI.html fails if we enable rcwn
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: CuveeHsu, Assigned: CuveeHsu)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
1.14 KB,
patch
|
kanru
:
review+
|
Details | Diff | Splinter Review |
Per Bug 1373198 Comment 22, a regression happens to test_browserElement_oop_ExposableURI.html if we enable rcwn.
It still exposed the user name.
FWIW, Bug 1377162 comment 1 elaborate some about the reproducing in local.
STR:
1. apply the patch in this Bug 1373198 Comment 27
2. run the mach mochitest --disable-e10s dom/browser-element/mochitest/test_browserElement_oop_ExposableURI.html
|
Assignee | |
Comment 1•9 years ago
|
||
Assign myself first.
Feel free to take it.
Assignee: nobody → juhsu
Whiteboard: [necko-active]
|
|
Assignee | |
Comment 2•9 years ago
|
||
When I see bug 795317, it seems about Browser API.
Do we still care much about |mozbrowserlocationchange|, Kanru?
If not, we can just disbale rcwn in this test.
Flags: needinfo?(kanru)
|
||
Comment 3•9 years ago
|
||
(In reply to Junior[:junior] from comment #2)
> When I see bug 795317, it seems about Browser API.
> Do we still care much about |mozbrowserlocationchange|, Kanru?
>
> If not, we can just disbale rcwn in this test.
I think it's OK to just disable rcwn for this test.
Flags: needinfo?(kanru)
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
|
Assignee | |
Comment 5•9 years ago
|
||
another shot with pref-on
https://treeherder.mozilla.org/#/jobs?repo=try&revision=057a34924d16ea35df0d3ce01a97f9619c3a867d
FWIW, Bug 1320433 can be reproduced in mac os if we run a one-file mochitest.
Hence, I need to push to treeherder to verify :p
|
|
Assignee | |
Comment 6•9 years ago
|
||
FWIW, mach try dom/browser-element/mochitest is buggy
Attachment #8887880 -
Flags: review?(kchen)
|
|
||
Updated•8 years ago
|
Attachment #8887880 -
Flags: review?(kchen) → review+
|
|
Assignee | |
Comment 7•8 years ago
|
||
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1476b84d8f87
disable rcwn to make cache behavior deterministic in test, r=kanru
Keywords: checkin-needed
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•