Closed Bug 1379899 Opened 3 years ago Closed 3 years ago

test_browserElement_oop_ExposableURI.html fails if we enable rcwn

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Per Bug 1373198 Comment 22, a regression happens to test_browserElement_oop_ExposableURI.html if we enable rcwn.

It still exposed the user name.

FWIW, Bug 1377162 comment 1 elaborate some about the reproducing in local.

STR:
1. apply the patch in this Bug 1373198 Comment 27
2. run the mach mochitest --disable-e10s dom/browser-element/mochitest/test_browserElement_oop_ExposableURI.html
Assign myself first.
Feel free to take it.
Assignee: nobody → juhsu
Whiteboard: [necko-active]
When I see bug 795317, it seems about Browser API.
Do we still care much about |mozbrowserlocationchange|, Kanru?

If not, we can just disbale rcwn in this test.
Flags: needinfo?(kanru)
(In reply to Junior[:junior] from comment #2)
> When I see bug 795317, it seems about Browser API.
> Do we still care much about |mozbrowserlocationchange|, Kanru?
> 
> If not, we can just disbale rcwn in this test.

I think it's OK to just disable rcwn for this test.
Flags: needinfo?(kanru)
another shot with pref-on
https://treeherder.mozilla.org/#/jobs?repo=try&revision=057a34924d16ea35df0d3ce01a97f9619c3a867d

FWIW, Bug 1320433 can be reproduced in mac os if we run a one-file mochitest.
Hence, I need to push to treeherder to verify :p
Attached patch disableRCWN, v1Splinter Review
FWIW, mach try dom/browser-element/mochitest is buggy
Attachment #8887880 - Flags: review?(kchen)
Attachment #8887880 - Flags: review?(kchen) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1476b84d8f87
disable rcwn to make cache behavior deterministic in test, r=kanru
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1476b84d8f87
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.