1379909 - Can't run screenshot tests locally

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Johann Hofmann [:johannh]]

Not sure if this is the right component. I can't seem to run a mochitest command that has always worked for me in the past.

Running this command:

./mach mochitest --subsuite screenshots --setenv MOZSCREENSHOTS_SETS=PermissionPrompts                                                                                           

I get the following output:

Error running mach:

    ['mochitest', '--subsuite', 'screenshots', '--setenv', 'MOZSCREENSHOTS_SETS=PermissionPrompts']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

ValueError: Item already in manifest: testing/mochitest/tests/layout/style/test/Ahem.ttf

  File "/Users/johann/Development/firefox/testing/mochitest/mach_commands.py", line 315, in run_mochitest_general
    driver.install_tests(tests)
  File "/Users/johann/Development/firefox/python/mozbuild/mozbuild/controller/building.py", line 696, in install_tests
    '_tests', test_objs)
  File "/Users/johann/Development/firefox/python/mozbuild/mozbuild/testing.py", line 498, in install_test_files
    manifest.add_symlink(source, dest)
  File "/Users/johann/Development/firefox/python/mozbuild/mozpack/manifests.py", line 255, in add_symlink
    self._add_entry(dest, (self.SYMLINK, source))
  File "/Users/johann/Development/firefox/python/mozbuild/mozpack/manifests.py", line 328, in _add_entry
    raise ValueError('Item already in manifest: %s' % dest)

Running tests normally (./mach mochitest path/to/file.js) works. I have a clean build state on latest central AFAIK.

Comment 1

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/mozilla-central/rev/21f6ba7bb580 (bug 1375944) added file layout/style/test/Ahem.ttf and added a support-files annotation to the manifest. The manifest already had a support-files annotation for a different copy of Ahem.ttf for another test, https://hg.mozilla.org/mozilla-central/annotate/21f6ba7bb580/layout/style/test/mochitest.ini#l49.

Comment 2

[Geoff Brown [:gbrown]]

Attachment: change old support-files reference to use new copy

It looks like layout/reftests/fonts/Ahem.ttf is identical to layout/styles/test/Ahem.ttf. 

We can't have 2 references with the same filename but different sources.

I prefer the idea of having the support file in the test directory, so I've changed the old entry to use the new copy of Ahem.ttf. It works for me locally.

(We could use the layout/reftests copy instead, and delete the layout/styles one, or rename one and use both.)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c91dfa2e67
Update mochitest.ini annotation for Ahem.ttf support file; r=xidorn

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f8c91dfa2e67