1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Dão Gottwald [:dao]]

We may want to use -moz-win-accentcolor outside of the title bar, see bug 1366405 comment 6 for instance.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it.

Review commit: https://reviewboard.mozilla.org/r/156098/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156098/

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8885213 [details]
Bug 1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it.

https://reviewboard.mozilla.org/r/156098/#review161474

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8885213 [details]
Bug 1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156098/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a5d8de65b70
Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it. r=jimm

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5a5d8de65b70

Comment 6

[Richard Marti (:Paenglab)]

The accent color is no more shown. Tested with own built build and from https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win64/1499956580/

Dão could you look whats wrong? Does this need a backout?

Comment 7

[Dão Gottwald [:dao]]

(In reply to Richard Marti (:Paenglab) from comment #6)
> The accent color is no more shown. Tested with own built build and from
> https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-
> win64/1499956580/
> 
> Dão could you look whats wrong? Does this need a backout?

I had tested the patch when I investigated bug 1366405 and it worked, but I had to rebase the browser-aero.css part twice. It's possible that something went wrong. Looking at the patch, I don't see anything wrong, though.

Comment 8

[Richard Marti (:Paenglab)]

FX shows the dark background from the (-moz-windows-accent-color-in-titlebar: 0) media query but not the (-moz-windows-accent-color-in-titlebar). When I remove the query the accent color is used. For me it seems it doesn't recognize the -moz-windows-accent-color-in-titlebar.

Comment 9

[Dão Gottwald [:dao]]

Okay, I can reproduce. Backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/16fb9739ca1ee6af945b34715d8ba9730761e33e

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Merged backout https://hg.mozilla.org/mozilla-central/rev/16fb9739ca1e

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8885213 [details]
Bug 1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156098/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad8cd3c31fd
Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it. r=jimm

Comment 13

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fad8cd3c31fd

Comment 15

[Chris Mills [:cmills]]

This is documented — see https://bugzilla.mozilla.org/show_bug.cgi?id=1344910#c27