Closed Bug 1379938 Opened 2 years ago Closed 2 years ago

Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it

Categories

(Core :: Widget: Win32, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

We may want to use -moz-win-accentcolor outside of the title bar, see bug 1366405 comment 6 for instance.
Comment on attachment 8885213 [details]
Bug 1379938 - Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it.

https://reviewboard.mozilla.org/r/156098/#review161474
Attachment #8885213 - Flags: review?(jmathies) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a5d8de65b70
Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it. r=jimm
https://hg.mozilla.org/mozilla-central/rev/5a5d8de65b70
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
The accent color is no more shown. Tested with own built build and from https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win64/1499956580/

Dão could you look whats wrong? Does this need a backout?
Flags: needinfo?(dao+bmo)
(In reply to Richard Marti (:Paenglab) from comment #6)
> The accent color is no more shown. Tested with own built build and from
> https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-
> win64/1499956580/
> 
> Dão could you look whats wrong? Does this need a backout?

I had tested the patch when I investigated bug 1366405 and it worked, but I had to rebase the browser-aero.css part twice. It's possible that something went wrong. Looking at the patch, I don't see anything wrong, though.
Flags: needinfo?(dao+bmo)
FX shows the dark background from the (-moz-windows-accent-color-in-titlebar: 0) media query but not the (-moz-windows-accent-color-in-titlebar). When I remove the query the accent color is used. For me it seems it doesn't recognize the -moz-windows-accent-color-in-titlebar.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Merged backout https://hg.mozilla.org/mozilla-central/rev/16fb9739ca1e
Target Milestone: mozilla56 → ---
Blocks: 1381496
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fad8cd3c31fd
Rename the -moz-windows-accent-color-applies media query and make -moz-win-accentcolor available without it. r=jimm
We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.
https://hg.mozilla.org/mozilla-central/rev/fad8cd3c31fd
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.