1379952 - Unreadable font while clicking on “Find a replacement” button

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

[Affected versions]:
Firefox 56.0a1 (2017-07-10)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit
Mac OS X 10.12.1

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install a legacy add-on.
3.Navigate to about:config and toggle the value of extensions.legacy.enabled to false
4.Go to about:addons -> Legacy Extensions tab.
5.Click on "Find a Replacement" button.


[Expected Results]:
“Find a Replacement” button has a readable font on click.


[Actual Results]:
- The background button becomes gray on click and the text maintains its white font color.
- See attached screencast.

[Additional notes]:
Considering that extensions.legacy.enabled is true in Firefox 55 I will mark this version as disabled.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1379952 - Update button colors in legacy about:addons pane

Review commit: https://reviewboard.mozilla.org/r/159324/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159324/

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: find-a-replacement-active.gif

I updated all of the states to match the photon colours.

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8888370 [details]
Bug 1379952 - Update button colors in legacy about:addons pane

https://reviewboard.mozilla.org/r/159324/#review165484

It would be nice to just use css variables here but no need to take that on in this bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36f1cb0b2adb
Update button colors in legacy about:addons pane r=aswan

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/36f1cb0b2adb

Comment 6

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

Verified as fixed on Firefox 56.0a1 (2017-07-30/31) under Windows 10 64-bit and Mac OS X 10.12.3. “Find a Replacement” button has a blue readable font on click.