1380083 - icu uses Windows-only backslash in include

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement)

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

Review commit: https://reviewboard.mozilla.org/r/156238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156238/

Comment 2

[Makoto Kato [:m_kato]]

You need patch file to intl/icu-patches.

Comment 3

[André Bargull [:anba]]

Can you import the complete patch (http://bugs.icu-project.org/trac/changeset/40102) from upstream ICU? Thanks!

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8885393 [details]
Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156238/diff/1-2/

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8885393 [details]
Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156238/diff/2-3/

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8885393 [details]
Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156238/diff/3-4/

Comment 7

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Okay, updated. André, can you review? (I cannot get your name to work inside of mozreview...)

Comment 8

[André Bargull [:anba]]

Comment on attachment 8885393 [details]
Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

https://reviewboard.mozilla.org/r/156238/#review161704

LGTM!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This doesn't meet the review requirements in MozReview for Autoland to push it.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8885393 [details]
Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

https://reviewboard.mozilla.org/r/156236/#review161898

Comment 11

[Makoto Kato [:m_kato]]

reviewboard cannot set r=me.  So I will push this with r=me and andre.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb39f860d7b3
Pull in upstream ICU patch that changes '\' to '/' in #include. r=andre,m_kato

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eb39f860d7b3