Closed Bug 1380083 Opened 2 years ago Closed 2 years ago

icu uses Windows-only backslash in include

Categories

(Core :: JavaScript: Internationalization API, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor])

Attachments

(1 file)

You need patch file to intl/icu-patches.
Component: Internationalization → JavaScript: Internationalization API
Can you import the complete patch (http://bugs.icu-project.org/trac/changeset/40102) from upstream ICU? Thanks!
Okay, updated. André, can you review? (I cannot get your name to work inside of mozreview...)
Flags: needinfo?(andrebargull)
Comment on attachment 8885393 [details]
Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

https://reviewboard.mozilla.org/r/156238/#review161704

LGTM!
Attachment #8885393 - Flags: review+
Flags: needinfo?(andrebargull)
This doesn't meet the review requirements in MozReview for Autoland to push it.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits
Keywords: checkin-needed
Comment on attachment 8885393 [details]
Bug 1380083 Pull in upstream ICU patch that changes '\' to '/' in #include

https://reviewboard.mozilla.org/r/156236/#review161898
reviewboard cannot set r=me.  So I will push this with r=me and andre.
Attachment #8885393 - Flags: review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb39f860d7b3
Pull in upstream ICU patch that changes '\' to '/' in #include. r=andre,m_kato
https://hg.mozilla.org/mozilla-central/rev/eb39f860d7b3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.