1380094 - Separate non-extension form autofill changes made by sync

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P1)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

This code is a rollup of the portions of the bug 1374500 and bug 1363999 patches that needs to ride the trains.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1380094 - services/sync changes to support formautofill

Review commit: https://reviewboard.mozilla.org/r/156252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156252/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8885402 [details]
Bug 1380094 - services/sync changes to support formautofill

https://reviewboard.mozilla.org/r/156252/#review161520

Awesome, thanks!

::: services/sync/services-sync.js:21
(Diff revision 1)
>  pref("services.sync.scheduler.fxa.singleDeviceInterval", 3600); // 1 hour
>  
>  pref("services.sync.errorhandler.networkFailureReportTimeout", 1209600); // 2 weeks
>  
> +// Note that new engines are typically added with a default of disabled, so
> +// when an existing sync user get the Firefox upgrade that supports the engine

a couple of typos from me in this comment :)

*gets* the Firefox upgrade..
*it* starts as disabled...

Comment 3

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8885402 [details]
Bug 1380094 - services/sync changes to support formautofill

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156252/diff/1-2/

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8885402 [details]
Bug 1380094 - services/sync changes to support formautofill

https://reviewboard.mozilla.org/r/156252/#review161520

> a couple of typos from me in this comment :)
> 
> *gets* the Firefox upgrade..
> *it* starts as disabled...

Yep. (Note that the interdiff might look weird since I did a sanity-check rebase against eoger's patches which will almost certainly land first).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fb3318c574b
services/sync changes to support formautofill r=markh

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2fb3318c574b