All users were logged out of Bugzilla on October 13th, 2018

Separate non-extension form autofill changes made by sync

RESOLVED FIXED in Firefox 56

Status

()

P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: tcsc, Assigned: tcsc)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This code is a rollup of the portions of the bug 1374500 and bug 1363999 patches that needs to ride the trains.
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → tchiovoloni

Comment 2

a year ago
mozreview-review
Comment on attachment 8885402 [details]
Bug 1380094 - services/sync changes to support formautofill

https://reviewboard.mozilla.org/r/156252/#review161520

Awesome, thanks!

::: services/sync/services-sync.js:21
(Diff revision 1)
>  pref("services.sync.scheduler.fxa.singleDeviceInterval", 3600); // 1 hour
>  
>  pref("services.sync.errorhandler.networkFailureReportTimeout", 1209600); // 2 weeks
>  
> +// Note that new engines are typically added with a default of disabled, so
> +// when an existing sync user get the Firefox upgrade that supports the engine

a couple of typos from me in this comment :)

*gets* the Firefox upgrade..
*it* starts as disabled...
Attachment #8885402 - Flags: review?(markh) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 4

a year ago
mozreview-review-reply
Comment on attachment 8885402 [details]
Bug 1380094 - services/sync changes to support formautofill

https://reviewboard.mozilla.org/r/156252/#review161520

> a couple of typos from me in this comment :)
> 
> *gets* the Firefox upgrade..
> *it* starts as disabled...

Yep. (Note that the interdiff might look weird since I did a sanity-check rebase against eoger's patches which will almost certainly land first).

Comment 5

a year ago
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fb3318c574b
services/sync changes to support formautofill r=markh

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2fb3318c574b
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.