Closed Bug 1380139 Opened 8 years ago Closed 8 years ago

Pin to Overflow Menu Icon Drop motion

Categories

(Firefox :: Theme, enhancement, P1)

Product:
Firefox
Component:
Theme
Version:
56 Branch
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 57
Iteration:
57.1 - Aug 15
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: epang, Assigned: jaws)

Details

(Whiteboard: [reserve-photon-animation])

Attachments

(3 files)

overflow-iconmotion.mp4
28.74 KB, video/mp4
Details
Stand Alone Icon (SVG + JSON).zip
318.75 KB, application/zip
Details
Bug 1380139 - Change the 'Pin to Overflow Menu' animation to not move the arrow as much.
59 bytes, text/x-review-board-request
sfoster
: review+
Details
The second part of the pin to overflow menu needs to be implemented. I will follow up with specs for the motion of the icon dropping into the overflow menu.
Whiteboard: [photon-animation] → [photon-animation][triage]
Priority: P1 → --
Flags: qe-verify+
Priority: -- → P2
QA Contact: jwilliams
Whiteboard: [photon-animation][triage] → [photon-animation]
Priority: P2 → P3
Whiteboard: [photon-animation] → [reserve-photon-animation]
Attached video overflow-iconmotion.mp4 —
Spec for icon drop 1. Icon Starting Point Size: 90% Opacity: 0% Position: 36px above clipping point of overflow icon Rotation: 20° 2. Icon Drop Part 1 Start at 0ms Duration: 80ms Size: 90% > 75% Opacity: 0% > 100% Rotation: 20° > 0° 2. Icon Drop Part 2 Start at 80ms Duration: 340ms Rotation: 0° > -30° Position: 36px vertical drop Start 290ms Duration 40ms Opacity: 100% > 0% apply an easy ease to the segments of all motions (ease in + out)
Flags: needinfo?(jaws)
Flags: needinfo?(jaws)
Whiteboard: [reserve-photon-animation] → [photon-animation]
Whiteboard: [photon-animation] → [reserve-photon-animation]
In case we aren't able to add in the icon drop here's a back up svg sprite with the overflow icon as a stand alone.
Whiteboard: [reserve-photon-animation] → [photon-animation]
Priority: P3 → P2
Priority: P2 → P3
Whiteboard: [photon-animation] → [reserve-photon-animation]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 57.1 - Aug 15
Priority: P3 → P1
Comment on attachment 8895473 [details] Bug 1380139 - Change the 'Pin to Overflow Menu' animation to not move the arrow as much. https://reviewboard.mozilla.org/r/166674/#review171900 Looks good.
Attachment #8895473 - Flags: review?(sfoster) → review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee93e0ee55df Change the 'Pin to Overflow Menu' animation to not move the arrow as much. r=sfoster
https://hg.mozilla.org/mozilla-central/rev/ee93e0ee55df
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
I have reproduced this bug with Nightly 56.0a1 (2017-07-11) on Ubuntu 16.04, 64 bit! The fix is now verified on Latest Nightly 57.0a1 . Build ID 20170829100404 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
QA Whiteboard: [bugday-20170830]
I have successfully reproduced this bug with Nightly 56.0a1 (2017-07-11) on windows 10(32bit) this bug is verified fix with latest nightly 57.0a1 (2017-08-29) (32-bit) Build ID: 20170829100404 Mozilla/5.0 (Windows NT 10.0; rv:57.0) Gecko/20100101 Firefox/57.0 [bugday-20170830]
As per Comment 7 and Comment 8, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: