Closed
Bug 1380147
Opened 7 years ago
Closed 7 years ago
GET_MODULE_HANDLE_EX_UNCHANGED_REFCOUNT is not an actual constant
Categories
(Core :: IPC, enhancement)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
In ipc/mscom/Utils.cpp we use GET_MODULE_HANDLE_EX_UNCHANGED_REFCOUNT. This is not an actual flag, the correct one is GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT. This breaks the MinGW build because MinGW doesn't know about the _FLAG_-less one. https://msdn.microsoft.com/en-us/library/windows/desktop/ms683200?f=255&MSPPError=-2147217396 seems to have a typo in the remarks section. See also https://sourceforge.net/p/mingw-w64/bugs/636/ for discussion. (I'm going to wait until Bug 1380092 lands to avoid a weird landing dependency as they are right next to each other.)
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8885838 -
Flags: review?(jld)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8885838 [details] Bug 1380147 Correct Windows flag name https://reviewboard.mozilla.org/r/156614/#review162932 I don't know much about ipc/mscom, but judging by https://hg.mozilla.org/mozilla-central/rev/97795bcd29b1#l2.73 this looks like the right change.
Attachment #8885838 -
Flags: review?(jld) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/47cb5063c8f5 Correct Windows flag name r=jld
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/47cb5063c8f5
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•