[Fennec][HLS] Make access to mIsPlayerInitDone & mResourceCallback guarded.

RESOLVED FIXED in Firefox 56

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kikuo, Assigned: kikuo)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
From https://scan4.coverity.com/reports.htm#v27748/p11134/fileInstanceId=22191825&defectInstanceId=4435480&mergedDefectId=147724,  there are 4 unguarded read/write defects (CID : 147724 / 147725 / 147726 / 147727).

It won't lead to an unexpected result, It's better to make them safe.
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8885596 [details]
Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded.

https://reviewboard.mozilla.org/r/156448/#review161566
Attachment #8885596 - Flags: review?(jacheng) → review+

Comment 3

a year ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 34c4ded4c997 -d 3b419fb92d30: rebasing 406756:34c4ded4c997 "Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded. r=JamesCheng" (tip)
merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/BaseHlsPlayer.java
merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java
warning: conflicts while merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
(Assignee)

Comment 4

a year ago
mozreview-review
Comment on attachment 8885596 [details]
Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded.

https://reviewboard.mozilla.org/r/156448/#review161660

rebase
Comment hidden (mozreview-request)

Comment 6

a year ago
Pushed by kikuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/835d645c14f0
Make access to some members in GeckoHlsPlayer guarded. r=JamesCheng

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/835d645c14f0
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.