Closed Bug 1380201 Opened 3 years ago Closed 3 years ago
[Fennec][HLS] Make access to m
Is Player Init Done & m Resource Callback guarded .
59 bytes, text/x-review-board-request
From https://scan4.coverity.com/reports.htm#v27748/p11134/fileInstanceId=22191825&defectInstanceId=4435480&mergedDefectId=147724, there are 4 unguarded read/write defects (CID : 147724 / 147725 / 147726 / 147727). It won't lead to an unexpected result, It's better to make them safe.
Comment on attachment 8885596 [details] Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded. https://reviewboard.mozilla.org/r/156448/#review161566
Attachment #8885596 - Flags: review?(jacheng) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 34c4ded4c997 -d 3b419fb92d30: rebasing 406756:34c4ded4c997 "Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded. r=JamesCheng" (tip) merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/BaseHlsPlayer.java merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java warning: conflicts while merging mobile/android/geckoview/src/main/java/org/mozilla/gecko/media/GeckoHlsPlayer.java! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment on attachment 8885596 [details] Bug 1380201 - Make access to some members in GeckoHlsPlayer guarded. https://reviewboard.mozilla.org/r/156448/#review161660 rebase
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/835d645c14f0 Make access to some members in GeckoHlsPlayer guarded. r=JamesCheng
You need to log in before you can comment on or make changes to this bug.