1380263 - Should data: URI inherit origin attributes when it is unique opaque origin?

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

From Bug 1324406 we're trying to make data: URI has a unique opage origin, and right now data: URI will inherit origin attributes from its parent, as done in bug 1300671. 

However one question remained is that, should the data: URI still inherit the origin attributes from its parent when we turn on the pref? or should it have its own unique origin attributes as well? or it shouldn't have any origin attributes at all?

Arthur, smaug, do you have any comment?

Thanks

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

It should inherit. Say, you have page from domain A which has iframe data:foo and that then has iframe from domain A. I certainly would expect usercontextID of the main page and the innermost iframe to be the same. Private browsing flag should be inherited too, and InIsolatedMozBrowser, and appid.
And since FirstPartyDomain is about top level pages, it should too.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

In other words, data: shouldn't be any different to random third party origin, I think.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8887408 [details] [diff] [review]
Patch

ahaa, DocShell code is getting hard to follow.
'inherit' means in the patch only that origin attributes are inherited.
Could you rename inherit to inheritOriginAttributes, or perhaps even more clear
(even though very long), inheritOriginAttributesAndMaybePrincipal

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

rename to inheritAttrs and inheritPrincipal.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c869a61f3eab
data: URI should inherit origin attributes. r=smaug

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c869a61f3eab