Closed Bug 138028 Opened 22 years ago Closed 22 years ago

accesskey="&more.label;" should be accesskey="&more.accesskey;"

Categories

(SeaMonkey :: MailNews: Message Display, defect)

Product:
SeaMonkey
Component:
MailNews: Message Display
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.1beta

People

(Reporter: ruixu, Assigned: nhottanscp)

References

Details

(Keywords: intl, Whiteboard: [adt3 rtm])

Attachments

(1 file)

Set a correct accesskey value for "more".
799 bytes, patch
naving
: review+
Bienvenu
: superreview+
jesup
: approval+
Details | Diff | Splinter Review 
This is separated from bug http://bugscape.netscape.com/show_bug.cgi?id=13834, and need more fix in general.

As per rchen's comments in bugscape bug 13834:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/s
earchTermOverlay.xul#79 

accesskey="&more.label;" should be accesskey="&more.accesskey;"
It caused shortcut issue on localized build. -> nsbeta1
Keywords: nsbeta1
Michele, we need to plus this low risk bug fix.
could anyone make a patch for it ?
Blocks: 141008
nhotta- can you put a patch for this one?
Assignee: sspitzer → nhotta
cc to naving, could you review the patch?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1beta
Comment on attachment 83388 [details] [diff] [review]
Set a correct accesskey value for "more".

r=naving
Attachment #83388 - Flags: review+
Comment on attachment 83388 [details] [diff] [review]
Set a correct accesskey value for "more".

sr=bienvenu
Attachment #83388 - Flags: superreview+
easy stuff, nsbeta1+
Keywords: nsbeta1 → intl, nsbeta1+
checked in to the trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
rui- can you verified this on trunk?
adding adt1.0.0+.  Please get drivers approval and then checkin to the 1.0 branch.
Keywords: adt1.0.0+, approval
Whiteboard: [adt3 rtm]
Comment on attachment 83388 [details] [diff] [review]
Set a correct accesskey value for "more".

a=rjesup@wgate.com for drivers; please check into branch asap
Attachment #83388 - Flags: approval+
checked in to the branch
Keywords: fixed1.0.0
Verified on trunk.
I don't have a localized build. Who can verify it on Branch?
You don't need a localized build to verify it on Branch.  Just go to the dtd 
file and modify the entity "more.accesskey" to some other character (other than 
the first letter of more.label) and see if it reflects the change.
Verified on branch 20020521.
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.0 → verified1.0.0
Blocks: 146292
No longer blocks: 141008
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: