accesskey="&more.label;" should be accesskey="&more.accesskey;"

VERIFIED FIXED in mozilla1.1beta

Status

defect
VERIFIED FIXED
17 years ago
15 years ago

People

(Reporter: ruixu, Assigned: nhottanscp)

Tracking

({intl})

Trunk
mozilla1.1beta
x86
Windows 2000
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt3 rtm])

Attachments

(1 attachment)

Reporter

Description

17 years ago
This is separated from bug http://bugscape.netscape.com/show_bug.cgi?id=13834, and need more fix in general.

As per rchen's comments in bugscape bug 13834:
http://lxr.mozilla.org/seamonkey/source/mailnews/base/search/resources/content/s
earchTermOverlay.xul#79 

accesskey="&more.label;" should be accesskey="&more.accesskey;"
Reporter

Comment 1

17 years ago
It caused shortcut issue on localized build. -> nsbeta1
Keywords: nsbeta1

Comment 2

17 years ago
Michele, we need to plus this low risk bug fix.

Comment 3

17 years ago
could anyone make a patch for it ?
Blocks: 141008

Comment 4

17 years ago
nhotta- can you put a patch for this one?
Assignee: sspitzer → nhotta
Assignee

Comment 6

17 years ago
cc to naving, could you review the patch?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1beta

Comment 7

17 years ago
Comment on attachment 83388 [details] [diff] [review]
Set a correct accesskey value for "more".

r=naving
Attachment #83388 - Flags: review+

Comment 8

17 years ago
Comment on attachment 83388 [details] [diff] [review]
Set a correct accesskey value for "more".

sr=bienvenu
Attachment #83388 - Flags: superreview+

Comment 9

17 years ago
easy stuff, nsbeta1+
Keywords: nsbeta1intl, nsbeta1+
Assignee

Comment 10

17 years ago
checked in to the trunk
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
rui- can you verified this on trunk?

Comment 12

17 years ago
adding adt1.0.0+.  Please get drivers approval and then checkin to the 1.0 branch.
Keywords: adt1.0.0+, approval
Whiteboard: [adt3 rtm]
Comment on attachment 83388 [details] [diff] [review]
Set a correct accesskey value for "more".

a=rjesup@wgate.com for drivers; please check into branch asap
Attachment #83388 - Flags: approval+
Assignee

Comment 14

17 years ago
checked in to the branch
Keywords: fixed1.0.0
Reporter

Comment 15

17 years ago
Verified on trunk.

Comment 16

17 years ago
I don't have a localized build. Who can verify it on Branch?

Comment 17

17 years ago
You don't need a localized build to verify it on Branch.  Just go to the dtd 
file and modify the entity "more.accesskey" to some other character (other than 
the first letter of more.label) and see if it reflects the change.
Reporter

Comment 18

17 years ago
Verified on branch 20020521.
Status: RESOLVED → VERIFIED

Updated

17 years ago
Blocks: 146292
No longer blocks: 141008
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.