1380290 - Options page can no longer receive messages from the background page

Status: VERIFIED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Wladimir Palant]

Attachment: Test extension

Steps to reproduce:

* Go to about:debugging and load the attached extension as a temporary extension.
* Go to about:addons, find "WebExtensions test" in the list and click its "Preferences" button.
* Press Ctrl/Cmd+Shift+J to open Browser Console, have a look at the messages.

Expected results:

Both "ping" and "pong" are listed in the Browser Console - the options page sent a message to the background page and received a response back. That's the behavior I see in Firefox 54 and Chrome 59.

Actual results:

Only "ping" is listed in the Browser Console, the response hasn't been received by the options page - tested with Firefox 56.0a1 nightly (2017-07-11) on Ubuntu. This affects both communication via plain messages and ports. I'm fairly certain that it used to work only a few days ago, so a pretty recent regression.

Comment 1

[YF (Yang)]

WFM in Nightly 56.0a1 (2017-07-11) x86 on Win10.

Comment 2

[Wladimir Palant]

Attachment: Test extension

My bad, not sure what went wrong with my testing. This seems to affect port-based communication only, which is what I was doing initially. I replaced the test extension by one using ports to communicate and verified that the issue is reproducible with a clean profile on Firefox 56.0a1 nightly (2017-07-12) on Ubuntu.

Comment 3

[YF (Yang)]

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=392ed89ec2730a48d10b1cec741e86a242d28aa3&tochange=a625a2e9b3333a8e76982ea65f077cfded6ac224

Comment 4

[Wladimir Palant]

Strange, extensions.webextensions.remote isn't the default on Linux and was indeed off for me. Which doesn't mean of course that it isn't a side-effect of one of those changes.

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1380290: Use correct message manager when communicating with inline options browsers.

Review commit: https://reviewboard.mozilla.org/r/156750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156750/

Comment 6

[Andrew Swan [:aswan]]

Comment on attachment 8885967 [details]
Bug 1380290: Use correct message manager when communicating with inline options browsers.

https://reviewboard.mozilla.org/r/156750/#review162112

eeew

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ce83907a2bc
Use correct message manager when communicating with inline options browsers. r=aswan

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ce83907a2bc

Comment 9

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial issue on Firefox 56.0a1 (2017-07-09) under Windows 10 64-bit.
Verified as fixed on Firefox 56.0a1 (2017-08-01) and Firefox 57.0a1 (2017-08-02) under Windows 10 64-bit and Ubuntu 16.04 32-bit. Both "ping" and "pong" are listed in the Browser Console.

Comment 10

[Wladimir Palant]

I forgot to retest this issue. In Firefox 57.0a1 (2017-08-02) on Ubuntu everything seems to be working as well, Easy Passwords 1.2.1 options are working - it has been released as a Web Extension in the meantime.