1380301 - Perma Bustage when Gecko moves to 56 in nsDeviceContextSpecWin.h(30): error C2039: 'PDFViaEMFPrintHelper': is not a member of 'mozilla::widget'

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P1)

Description

[Carsten Book [:Tomcat]]

uplift simulation from trunk as beta in preparation of the merge from 56 to beta shows bustage like :

 z:\build\build\src\widget\windows\nsDeviceContextSpecWin.h(30): error C2039: 'PDFViaEMFPrintHelper': is not a member of 'mozilla::widget' 

https://treeherder.mozilla.org/logviewer.html#?job_id=113623229&repo=try

seems windows only but we need to fix this before merge day to avoid tree closures etc

Comment 1

[Carsten Book [:Tomcat]]

farmer, Johnathan: can you take a look ? thanks

Comment 3

[Farmer Tseng[:fatseng](inactive)]

(In reply to Carsten Book [:Tomcat] from comment #1)
> farmer, Johnathan: can you take a look ? thanks

I will check it soon.

Comment 4

[Farmer Tseng[:fatseng](inactive)]

Attachment: Bug 1380301 - Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h

Review commit: https://reviewboard.mozilla.org/r/156804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156804/

Comment 5

[Farmer Tseng[:fatseng](inactive)]

Attachment: Bug 1380301 - Add windows.h include to nsLookAndFeel.h

Review commit: https://reviewboard.mozilla.org/r/156806/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156806/

Comment 6

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8886024 [details]
Bug 1380301 - Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156804/diff/1-2/

Comment 7

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8886025 [details]
Bug 1380301 - Add windows.h include to nsLookAndFeel.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156806/diff/1-2/

Comment 8

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8886024 [details]
Bug 1380301 - Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h

When Skia PDF build flag is disabled, gecko hit following build error.
I add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h to fix the build break.

11:54:01     INFO -  z:\build\build\src\widget\windows\nsDeviceContextSpecWin.h(30): error C2039: 'PDFViaEMFPrintHelper': is not a member of 'mozilla::widget'
11:54:01     INFO -  z:\build\build\src\widget\windows\JumpListBuilder.h(28): note: see declaration of 'mozilla::widget'
11:54:01     INFO -  z:\build\build\src\widget\windows\nsDeviceContextSpecWin.h(30): error C3646: 'PDFViaEMFPrintHelper': unknown override specifier
11:54:01     INFO -  z:\build\build\src\widget\windows\nsDeviceContextSpecWin.h(30): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
11:54:01     INFO -  z:/build/build/src/config/rules.mk:1040: recipe for target 'nsWidgetFactory.obj' failed
11:54:01     INFO -  mozmake.EXE[6]: *** [nsWidgetFactory.obj] Error 2
11:54:01     INFO -  mozmake.EXE[6]: *** Waiting for unfinished jobs....

Comment 9

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8886025 [details]
Bug 1380301 - Add windows.h include to nsLookAndFeel.h

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156806/diff/2-3/

Comment 10

[Farmer Tseng[:fatseng](inactive)]

Attachment: Bug 1380301 - Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h

Review commit: https://reviewboard.mozilla.org/r/156820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156820/

Comment 11

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8886025 [details]
Bug 1380301 - Add windows.h include to nsLookAndFeel.h

This is another build break.
It misses adding windows.h include in nsLookAndFeel.h

11:54:08     INFO -  z:\build\build\src\obj-firefox\dist\include\nsIWindowsRegKey.h(53): error C2061: syntax error: identifier 'HKEY'
11:54:08     INFO -  z:\build\build\src\obj-firefox\dist\include\nsIWindowsRegKey.h(54): error C2061: syntax error: identifier 'HKEY'
11:54:08     INFO -  z:/build/build/src/config/rules.mk:1040: recipe for target 'Unified_cpp_widget_windows2.obj' failed
11:54:08     INFO -  mozmake.EXE[6]: *** [Unified_cpp_widget_windows2.obj] Error 2
11:54:08     INFO -  mozmake.EXE[6]: Leaving directory 'z:/build/build/src/obj-firefox/widget/windows'
11:54:08     INFO -  z:/build/build/src/config/recurse.mk:73: recipe for target 'widget/windows/target' failed
11:54:08     INFO -  mozmake.EXE[5]: *** [widget/windows/target] Error 2
11:54:08     INFO -  mozmake.EXE[5]: *** Waiting for unfinished jobs....

Comment 12

[Cameron McCormack (:heycam)]

Comment on attachment 8886034 [details]
Bug 1380301 - Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h

https://reviewboard.mozilla.org/r/156820/#review161922

Comment 13

[Cameron McCormack (:heycam)]

Comment on attachment 8886025 [details]
Bug 1380301 - Add windows.h include to nsLookAndFeel.h

https://reviewboard.mozilla.org/r/156806/#review161924

r=me though make sure you do a build try run because I know that new windows.h inclusions can cause issues due some of the macros it defines.

Comment 14

[Farmer Tseng[:fatseng](inactive)]

Here is my build try runs.

Enable Skia PDF: https://treeherder.mozilla.org/#/jobs?repo=try&revision=99bbaa474ef3ae787920490cc9c030ed86b38a1c

Disable Skia PDF: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b64ba6d9a1a7a50796aee2d4ee8b64b5ce5be4cb

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ceb427e8afa
Add missing "#ifdef MOZ_ENABLE_SKIA_PDF" to nsDeviceContextSpecWin.h r=heycam
https://hg.mozilla.org/integration/autoland/rev/621c06836799
Add windows.h include to nsLookAndFeel.h r=heycam

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ceb427e8afa
https://hg.mozilla.org/mozilla-central/rev/621c06836799

Comment 17

[Rail Aliiev [:rail]]

Worked fine on jamun. Thank you for the fix!