Closed Bug 138040 Opened 23 years ago Closed 23 years ago

Publish Failed quickly turns into Publishing Completed in status panel

Categories

(SeaMonkey :: Composer, defect)

Product:
SeaMonkey
Component:
Composer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: sujay, Assigned: cmanske)

References

Details

(Whiteboard: publish [adt1 RTM][fixed in branch], custrtm-)

Attachments

(1 file, 2 obsolete files)

patch v2
737 bytes, patch
Brade
: review+
kinmoz
: superreview+
Details | Diff | Splinter Review
using 4/17 build of netscape 1) launch netscape 2) launch composer 3) enter text 4) publish somewhere notice in the progress panel right above the files being transferred it changes from "Publish Failed" quickly to "Publishing Completed" we should not show "Publishing Failed" at all unless it really does fail.
I have also seen this when uploading some large images. Thanks for filing this bug Sujay! I've been meaning to file it myself for a day or two now.
Whiteboard: publish
Attached patch patch v1 (obsolete) — — Splinter Review
simple fix
Status: NEW → ASSIGNED
Keywords: nsbeta1, patch, review
Whiteboard: publish → publish, FIX IN HAND, need r=,sr=
Comment on attachment 79903 [details] [diff] [review] patch v1 r=brade (I assume you tested both successful publishing scenarios as well as failure publishing scenarios)
Attachment #79903 - Flags: review+
Yes. Tested with success and failure senarios.
Comment on attachment 79903 [details] [diff] [review] patch v1 sr=kin@netscape.com
Attachment #79903 - Flags: superreview+
checked into trunk
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: patch, review
Resolution: --- → FIXED
Whiteboard: publish, FIX IN HAND, need r=,sr= → publish,[FIX IN TRUNK][adt3]
REOPEN Now I see "undefined" right before it changes to "Publish Complete" it should be " " instead of "undefined" Kathy also agrees.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Hmmm. I don't see that happening. You are publishing a new file? Any images in it? Maybe some time lag in rewriting the string in debug vs. optimized builds.
Status: REOPENED → ASSIGNED
new file....w/o images...just simple text on the page...
I was able to reproduce this bug inserting an image that doesn't have a content-length header (the example url is in one of my bugs). That instance showed the wrong string because the publishing took longer (infinite?) so success string wasn't displayed yet. You could also try uploading a lot of large images all at once?
Comment on attachment 79903 [details] [diff] [review] patch v1 This was checked in
Attachment #79903 - Attachment is obsolete: true
Attached patch patch v2 (obsolete) — — Splinter Review
This prevents any "undefined" string from displaying
Whiteboard: publish,[FIX IN TRUNK][adt3] → publish,[adt3][rtm][FIX IN HAND] need r=,sr=
Target Milestone: --- → mozilla1.0
Comment on attachment 80998 [details] [diff] [review] patch v2 r=akkana
Attachment #80998 - Flags: review+
Whiteboard: publish,[adt3][rtm][FIX IN HAND] need r=,sr= → publish,[adt3][rtm][FIX IN HAND][need sr=]
Attached patch patch v2 — — Splinter Review
Simpler patch Per review, the second part of "patch v2" isn't necessary.
Attachment #80998 - Attachment is obsolete: true
Comment on attachment 81549 [details] [diff] [review] patch v2 r=brade
Attachment #81549 - Flags: review+
Comment on attachment 81549 [details] [diff] [review] patch v2 sr=kin@netscape.com
Attachment #81549 - Flags: superreview+
Whiteboard: publish,[adt3][rtm][FIX IN HAND][need sr=] → publish,[adt3][rtm][FIX IN HAND][reviewed]
checked into trunk new revision: 1.5; previous revision: 1.4
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Keywords: nsbeta1 → nsbeta1+
Resolution: --- → FIXED
Whiteboard: publish,[adt3][rtm][FIX IN HAND][reviewed] → publish [adt3 RTM]
verified in 2002050104
This looks good to me also on the 05-01 trunk build. I am marking VERIFIED. If anyone is still able to reproduce this bug, feel free to reopen it.
Status: RESOLVED → VERIFIED
*** Bug 141682 has been marked as a duplicate of this bug. ***
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending Drivers approval. After, checking in, please add the fixed1.0 keyword.
Keywords: approval
Whiteboard: publish [adt3 RTM] → publish [adt1 RTM] [Needs a=]
Keywords: adt1.0.0+
Whiteboard: publish [adt1 RTM] [Needs a=] → publish [adt1 RTM] [Needs a=] custrtm-
changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1 milestone. Please get drivers approval before checking in.
Keywords: adt1.0.0+ → adt1.0.1+
Keywords: mozilla1.0.1
Target Milestone: mozilla1.0 → mozilla1.0.1
a=chofmann for 1.0.1
Keywords: mozilla1.0.1 → mozilla1.0.1+
Whiteboard: publish [adt1 RTM] [Needs a=] custrtm- → publish [adt1 RTM]approved, custrtm-
checked into mozilla1.0.1 branch
Keywords: mozilla1.0.1+ → fixed1.0.1
Whiteboard: publish [adt1 RTM]approved, custrtm- → publish [adt1 RTM][fixed in branch], custrtm-
verified in 6/4 branch build
Keywords: verified1.0.1
*** Bug 149249 has been marked as a duplicate of this bug. ***
removing fixed1.0.1 keyword
Keywords: fixed1.0.1
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: