Closed Bug 1380413 Opened 2 years ago Closed 2 years ago

Remove some unused nsIDOMHTMLImageElement bits

Categories

(Core :: DOM: Core & HTML, enhancement)

53 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

At least x/y are not used.
Comment on attachment 8886004 [details] [diff] [review]
part 1.  Remove unused nsIDOMHTMLImageElement bits

Review of attachment 8886004 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLImageElement.h
@@ +168,5 @@
>    void SetCrossOrigin(const nsAString& aCrossOrigin, ErrorResult& aError)
>    {
>      SetOrRemoveNullableStringAttr(nsGkAtoms::crossorigin, aCrossOrigin, aError);
>    }
> +  void GetUseMap(nsAString& aUseMap)

This is all some tedious code.
Attachment #8886004 - Flags: review?(continuation) → review+
Attachment #8886005 - Flags: review?(continuation) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/666ff5b5a597
part 1.  Remove unused nsIDOMHTMLImageElement bits.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/62015017951d
part 2.  Remove nsIDOMHTMLImageElement.width/height.  r=mccr8
https://hg.mozilla.org/mozilla-central/rev/666ff5b5a597
https://hg.mozilla.org/mozilla-central/rev/62015017951d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Apart from Get/SetSrc we also use GetLongDesc and GetName.

I can see:
https://hg.mozilla.org/mozilla-central/rev/62015017951d#l2.16
but HTMLImageElement is not a published class outside M-C, or is it?

How do I say it nicely? How come a huge chunk of the published IDL just got removed?
https://hg.mozilla.org/mozilla-central/rev/666ff5b5a597#l3.12
> How do I say it nicely? How come a huge chunk of the published IDL just got removed?

Because it's dead code as far as I could tell, and it's adding codesize we'd rather not be shipping.

HTMLImageElement is exported to mozilla/dom/HTMLImageElement.h.  Can Thunderbird not use that?
Flags: needinfo?(bzbarsky)
Oh, and the general plan is to slowly work on removing nsIDOM* bits in general, for the same reason.  So if Thunderbird is using those, you may want to see if you can work on stopping that.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.