1380413 - Remove some unused nsIDOMHTMLImageElement bits

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

At least x/y are not used.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove unused nsIDOMHTMLImageElement bits

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove nsIDOMHTMLImageElement.width/height

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 8886004 [details] [diff] [review]
part 1.  Remove unused nsIDOMHTMLImageElement bits

Review of attachment 8886004 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLImageElement.h
@@ +168,5 @@
>    void SetCrossOrigin(const nsAString& aCrossOrigin, ErrorResult& aError)
>    {
>      SetOrRemoveNullableStringAttr(nsGkAtoms::crossorigin, aCrossOrigin, aError);
>    }
> +  void GetUseMap(nsAString& aUseMap)

This is all some tedious code.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/666ff5b5a597
part 1.  Remove unused nsIDOMHTMLImageElement bits.  r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/62015017951d
part 2.  Remove nsIDOMHTMLImageElement.width/height.  r=mccr8

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/666ff5b5a597
https://hg.mozilla.org/mozilla-central/rev/62015017951d

Comment 6

[Jorg K (CEST = GMT+2)]

Hmm, that smashed TB. We use
https://dxr.mozilla.org/comm-central/rev/b61e73be467cef8a7231c42c0aba1a82ddfffada/mailnews/compose/src/nsMsgCompose.cpp#275
and we also use naturalWidth:
https://dxr.mozilla.org/comm-central/search?q=naturalWidth&redirect=false

You may want to comment on bug 1381011.

Comment 7

[Jorg K (CEST = GMT+2)]

Apart from Get/SetSrc we also use GetLongDesc and GetName.

I can see:
https://hg.mozilla.org/mozilla-central/rev/62015017951d#l2.16
but HTMLImageElement is not a published class outside M-C, or is it?

How do I say it nicely? How come a huge chunk of the published IDL just got removed?
https://hg.mozilla.org/mozilla-central/rev/666ff5b5a597#l3.12

Comment 8

[Boris Zbarsky [:bzbarsky]]

> How do I say it nicely? How come a huge chunk of the published IDL just got removed?

Because it's dead code as far as I could tell, and it's adding codesize we'd rather not be shipping.

HTMLImageElement is exported to mozilla/dom/HTMLImageElement.h.  Can Thunderbird not use that?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Oh, and the general plan is to slowly work on removing nsIDOM* bits in general, for the same reason.  So if Thunderbird is using those, you may want to see if you can work on stopping that.