Closed Bug 138048 Opened 22 years ago Closed 22 years ago

double click on card in addressbook side bar, doesn't bring up compose window.

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Product:
SeaMonkey
Component:
MailNews: Address Book & Contacts
Platform:
x86
Windows 2000
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0.1

People

(Reporter: sspitzer, Assigned: sspitzer)

References

Details

(Keywords: regression, Whiteboard: [fixed on trunk and branch] [adt2 rtm])

Attachments

(1 file)

fix
1.26 KB, patch
racham
: review+
Bienvenu
: superreview+
jesup
: approval+
Details | Diff | Splinter Review 
double click on card in addressbook side bar, doesn't bring up compose window.

you get a js error:

JavaScript error:
chrome://messenger/content/addressbook/abSelectAddressesDialog.js line 245: body
 has no properties

a regression caused by the fix for #121160

fix in hand.  the fix is to re-order how we include the .js files, as we want 
the addressbook-panels.js last, so that we use it's AbResultsPaneDoubleClick()
instead of the one in abSelectAddressesDialog.js
accepting.
Status: NEW → ASSIGNED
Keywords: regression
Target Milestone: --- → mozilla1.0
Comment on attachment 79683 [details] [diff] [review]
fix

sr=bienvenu
Attachment #79683 - Flags: superreview+
Comment on attachment 79683 [details] [diff] [review]
fix

r=bhuvan
Attachment #79683 - Flags: review+
Whiteboard: [fix in hand, have r=, sr=, will land on trunk today]
fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Keywords: adt1.0.0
Resolution: --- → FIXED
Whiteboard: [fix in hand, have r=, sr=, will land on trunk today] → [fixed on trunk]
Trunk build 2002-04-19-03: WinMe
Trunk build 2002-04-18-22: Linux RH 7.1
Trunk build 2002-04-19-03: Mac 10.1.3
Verified Fixed on the trunk. Double click on card in Sidebar Address Book and
the card's email address is prefilled in the Compose address area as expected.
Status: RESOLVED → VERIFIED
nsbeta1+/adt3. Yes, this is a regression, but not very severe. We can up the
Impact marking, if we think this hits a lot of users, and is determined to be a
very visible regression, or gross loss of functionality.
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [fixed on trunk] → [fixed on trunk] [adt3]
Adding adt1.0.0- and raising impact.  Let's reconsider this for rtm.
Keywords: adt1.0.0 → adt1.0.0-
Whiteboard: [fixed on trunk] [adt3] → [fixed on trunk] [adt2 rtm]
Keywords: adt1.0.0- → adt1.0.0
adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch, pending Driver's
approval.
Blocks: 143047
Keywords: adt1.0.0 → adt1.0.1+, mozilla1.0.1
seting TM to 1.0.1
Target Milestone: mozilla1.0 → mozilla1.0.1
Comment on attachment 79683 [details] [diff] [review]
fix

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword
Attachment #79683 - Flags: approval+
fixed on trunk and branch.
Keywords: mozilla1.0.1+ → fixed1.0.1
Whiteboard: [fixed on trunk] [adt2 rtm] → [fixed on trunk and branch] [adt2 rtm]
Branch build 2002-06-11: WinMe
verified1.0.1
Keywords: fixed1.0.1 → verified1.0.1
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: