If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove DispatchKeyNeededEvent from MediaFormatReader.cpp

RESOLVED FIXED in Firefox 56

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
To reduce the use of AbstractMediaDecoder.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Attachment #8886463 - Flags: review?(gsquelart)
Assignee: nobody → jwwang

Comment 2

2 months ago
mozreview-review
Comment on attachment 8886463 [details]
Bug 1380545 - remove DispatchKeyNeededEvent from MediaFormatReader.cpp.

https://reviewboard.mozilla.org/r/157258/#review162380
Attachment #8886463 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 3

2 months ago
Thanks!
Blocks: 1378295

Comment 4

2 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30d0b7f0183d
remove DispatchKeyNeededEvent from MediaFormatReader.cpp. r=gerald

Comment 5

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/30d0b7f0183d
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
I’m concerned that you’re moving functions to a class you want to remove (AbstractMediaDecoder) to a class that should be removed (MediaDecoderReader).
Only MediaFormatReader should remain, we no longer need the MediaDecoderReader base class.
Flags: needinfo?(jwwang)
ni? You guys, so you keep the above in mind before making changes.... thank you
Flags: needinfo?(gsquelart)
(Assignee)

Comment 8

2 months ago
Since mOnEncrypted is used by MFR only, it is easy to move OnEncrypted() from MDR to MFR. The function should be in MFR in the first place. But the reference to MDR from MediaDecoder prevents us from doing that. Once we remove MDR, we can have MediaDecoder reference MFR directly.
Flags: needinfo?(jwwang)
Flags: needinfo?(gsquelart)
You need to log in before you can comment on or make changes to this bug.