1380545 - Remove DispatchKeyNeededEvent from MediaFormatReader.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[JW Wang [:jwwang] [:jw_wang]]

To reduce the use of AbstractMediaDecoder.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1380545 - remove DispatchKeyNeededEvent from MediaFormatReader.cpp.

We will use MediaEventSource to dispatch the 'encrypted' events.

Review commit: https://reviewboard.mozilla.org/r/157258/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157258/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8886463 [details]
Bug 1380545 - remove DispatchKeyNeededEvent from MediaFormatReader.cpp.

https://reviewboard.mozilla.org/r/157258/#review162380

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30d0b7f0183d
remove DispatchKeyNeededEvent from MediaFormatReader.cpp. r=gerald

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/30d0b7f0183d

Comment 6

[Jean-Yves Avenard [:jya]]

I’m concerned that you’re moving functions to a class you want to remove (AbstractMediaDecoder) to a class that should be removed (MediaDecoderReader).
Only MediaFormatReader should remain, we no longer need the MediaDecoderReader base class.

Comment 7

[Jean-Yves Avenard [:jya]]

ni? You guys, so you keep the above in mind before making changes.... thank you

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Since mOnEncrypted is used by MFR only, it is easy to move OnEncrypted() from MDR to MFR. The function should be in MFR in the first place. But the reference to MDR from MediaDecoder prevents us from doing that. Once we remove MDR, we can have MediaDecoder reference MFR directly.