Closed Bug 1380545 Opened 2 years ago Closed 2 years ago

Remove DispatchKeyNeededEvent from MediaFormatReader.cpp

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

To reduce the use of AbstractMediaDecoder.
Attachment #8886463 - Flags: review?(gsquelart)
Assignee: nobody → jwwang
Comment on attachment 8886463 [details]
Bug 1380545 - remove DispatchKeyNeededEvent from MediaFormatReader.cpp.

https://reviewboard.mozilla.org/r/157258/#review162380
Attachment #8886463 - Flags: review?(gsquelart) → review+
Thanks!
Blocks: 1378295
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30d0b7f0183d
remove DispatchKeyNeededEvent from MediaFormatReader.cpp. r=gerald
https://hg.mozilla.org/mozilla-central/rev/30d0b7f0183d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
I’m concerned that you’re moving functions to a class you want to remove (AbstractMediaDecoder) to a class that should be removed (MediaDecoderReader).
Only MediaFormatReader should remain, we no longer need the MediaDecoderReader base class.
Flags: needinfo?(jwwang)
ni? You guys, so you keep the above in mind before making changes.... thank you
Flags: needinfo?(gsquelart)
Since mOnEncrypted is used by MFR only, it is easy to move OnEncrypted() from MDR to MFR. The function should be in MFR in the first place. But the reference to MDR from MediaDecoder prevents us from doing that. Once we remove MDR, we can have MediaDecoder reference MFR directly.
Flags: needinfo?(jwwang)
Flags: needinfo?(gsquelart)
You need to log in before you can comment on or make changes to this bug.