Closed Bug 1380545 Opened 2 years ago Closed 2 years ago
Key Needed Event from Media Format Reader .cpp
59 bytes, text/x-review-board-request
To reduce the use of AbstractMediaDecoder.
Attachment #8886463 - Flags: review?(gsquelart)
Comment on attachment 8886463 [details] Bug 1380545 - remove DispatchKeyNeededEvent from MediaFormatReader.cpp. https://reviewboard.mozilla.org/r/157258/#review162380
Attachment #8886463 - Flags: review?(gsquelart) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/30d0b7f0183d remove DispatchKeyNeededEvent from MediaFormatReader.cpp. r=gerald
I’m concerned that you’re moving functions to a class you want to remove (AbstractMediaDecoder) to a class that should be removed (MediaDecoderReader). Only MediaFormatReader should remain, we no longer need the MediaDecoderReader base class.
ni? You guys, so you keep the above in mind before making changes.... thank you
Since mOnEncrypted is used by MFR only, it is easy to move OnEncrypted() from MDR to MFR. The function should be in MFR in the first place. But the reference to MDR from MediaDecoder prevents us from doing that. Once we remove MDR, we can have MediaDecoder reference MFR directly.
You need to log in before you can comment on or make changes to this bug.