1380575 - In pane options page gets displayed for other extension option pages (with open_in_tab:true)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect, P1)

Description

[Kenny D]

Attachment: Cookie AutoDelete Settings with Favorite Color option page.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170710085521

Steps to reproduce:

1. Download the test extension here

https://bugzilla.mozilla.org/show_bug.cgi?id=1302504#c17

2. Download Cookie AutoDelete from here (which has open_in_tab:true for the options_ui key)

https://addons.mozilla.org/en-US/firefox/addon/cookie-autodelete/

3. Close and reload the addon manager page if open

4. Navigate to the Favorite Color addon extension page

5. Then navigate to Cookie AutoDelete's extension page


Actual results:

- The options page for the Favorite color addon is displayed in Cookie AutoDelete's setting page (See attached image)


Expected results:

- Favorite color's option menu should not have appeared in Cookie AutoDelete's settings page 
- Also this bug only appears on the options_ui key with open_in_tab:true

Comment 1

[Wesly Huang (EPM)]

[Traige@0719] Addon related.

Hi Andy, would you take a look and see if this should be in your priority list? Thanks

Comment 2

[Andy McKay]

Clearing, will be triaged in regular weekly triage.

Comment 3

[CosminB]

Attachment: FennecOptionsUI.gif

I can reproduce this issue on Firefox 56.0a1 (2017-07-20) under Android 6.0.1
Please have a look at the attached video.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1380575 - Fix EventEmitter lazy import for browserAction on Android.

Review commit: https://reviewboard.mozilla.org/r/162534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162534/

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1380575 - Fix Android WebExtension options page rendered on other extension details.

Review commit: https://reviewboard.mozilla.org/r/162536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162536/

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1380575 - Fix aListItem is undefined when uninstalling from Androud about:addons page.

Review commit: https://reviewboard.mozilla.org/r/162538/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/162538/

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8891341 [details]
Bug 1380575 - Fix aListItem is undefined when uninstalling from Androud about:addons page.

https://reviewboard.mozilla.org/r/162538/#review167882

Comment 8

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8891340 [details]
Bug 1380575 - Fix Android WebExtension options page rendered on other extension details.

https://reviewboard.mozilla.org/r/162536/#review167884

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8891339 [details]
Bug 1380575 - Fix EventEmitter lazy import for browserAction on Android.

https://reviewboard.mozilla.org/r/162534/#review167888

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ddcdf3491c2
Fix EventEmitter lazy import for browserAction on Android. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/69245ffa6a00
Fix Android WebExtension options page rendered on other extension details. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/8f349f00f666
Fix aListItem is undefined when uninstalling from Androud about:addons page. r=mixedpuppy

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ddcdf3491c2
https://hg.mozilla.org/mozilla-central/rev/69245ffa6a00
https://hg.mozilla.org/mozilla-central/rev/8f349f00f666

Comment 12

[CosminB]

Attachment: optionsFix.gif

This issue is verified as fixed on Fennec 57.0a1 (2017-08-16) and Fennec 56.0b3 under Android 6.0.1. 

The options_ui page from the Favourite color is not displayed in the Cookie AutoDelete's options_ui page.