1380585 - Come out with an approach to pref on/off the Photon visual refresh

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P2)

Description

[Ricky Chien [:rickychien] (inactive)]

Discussion thread has started from https://bugzilla.mozilla.org/show_bug.cgi?id=1357306#c3.

We should figure out a way to be able to pref on/off of Photon visual refresh change whatever using run-time or build-time approach.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

In reply to bug 1357306 comment 13, how about if we land the patch that I pushed to that bug, but instead of enabling this for Nightly builds we keep it disabled. Then developers can enable it on their machines but official Firefox 56 Nightly builds will not have it. Does that sound better?

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Yeah! Sounds great to me. Once we got Fx56 QA sign-off, we can enable the build flag in Nightly before the merge day.

Please submit your patch here and let's land it!

Thanks!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

The patch I'm attaching enables the pref on Nightly. We can use Cedar[1] for testing the non-57 code. Cedar has been in use to see what Firefox 56 will be, which will have the various photon build flags disabled.

[1] https://hg.mozilla.org/projects/cedar/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1380585 - Add MOZ_PHOTON_PREFERENCES build-time flag to help with implementing visual refresh of preferences.

Review commit: https://reviewboard.mozilla.org/r/158532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158532/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

When this lands, what will we need to do to get the pref disabled on Cedar?

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8887648 [details]
Bug 1380585 - Add MOZ_PHOTON_PREFERENCES build-time flag to help with implementing visual refresh of preferences.

https://reviewboard.mozilla.org/r/158532/#review163832

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8887648 [details]
Bug 1380585 - Add MOZ_PHOTON_PREFERENCES build-time flag to help with implementing visual refresh of preferences.

https://reviewboard.mozilla.org/r/158532/#review163934

Looks great! And then we can add ifdef marco within css file to pref on the visual feature.

```
%ifdef MOZ_PHOTON_PREFERENCES
...
%endif
```

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Yes, that is correct.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e79bfc74d149
Add MOZ_PHOTON_PREFERENCES build-time flag to help with implementing visual refresh of preferences. r=chmanchester,rickychien

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e79bfc74d149

Comment 11

[Ricky Chien [:rickychien] (inactive)]

Jared, how do you enable MOZ_PHOTON_PREFERENCES flag from mozconfig? Does it support artifact build?

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

The flag is enabled by default on local and Nightly builds. If you want to test without it, open /toolkit/moz.configure and set MOZ_PHOTON_PREFERENCES to default to False, like is done here for MOZ_PHOTON_ANIMATIONS and MOZ_PHOTON_THEME: https://hg.mozilla.org/projects/cedar/rev/b993c41fb851

QA will need to use builds from Cedar to test, as builds from Nightly will not actually be what ships in 56 because Nightly includes many Photon changes. All Photon changes are disabled on Cedar builds.

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

This is now disabled on Cedar, https://hg.mozilla.org/projects/cedar/rev/24f27a3637ac