1380598 - No “Legacy” badge displayed in “Legacy extensons”/“Unsupported” tab

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: 2017-07-13_1218.png

[Affected versions]:
Firefox 56.0a1 (2017-07-12)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Navigate to about:config and turn off the signatures pref “xpinstall.signatures.required”.
3.Install an unsigned add-on and an unsigned webextension.
4.Go back to about:config and set the following prefs:
xpinstall.signatures.required to true
extensions.legacy.enabled to false 
5.Restart the browser.
6.Go to about:addons -> Unsupported tab.


[Expected Results]:
“Legacy” badge is successfully displayed for all legacy add-ons in “Legacy Extensions”/”Unsupported” tab.


[Actual Results]:
- “Legacy” badge is not displayed for legacy add-ons in “Legacy Extensions”/”Unsupported” tab and therefore is no difference between old add-ons and webextensions.
- See attached screenshot.


[Additional notes]:
Considering that extensions.legacy.enabled is true in Firefox 55 I will mark this version as disabled.

Comment 1

[Andrew Swan [:aswan]]

This is as designed, see the UX mockups at https://mozilla.invisionapp.com/share/HUAUGBGWZ

Comment 2

[emanuela [ux]]

:vasilica_mihasca why are you confuse by this solution? 
In the “Legacy Extensions” the badge is an element that allow the users to understand why the extension is legacy and what does that mean. 

In ”Unsupported” we have a generic link of top (it should be the same we used for the badge) and all the extensions there are legacy (with some of them being legacy and unsigned)

Comment 3

[Vasilica Tamas, QA [:vtamas]]

So, to be more clear, by “Legacy” badge I’m referring to the yellow label that appears for each legacy add-on in “Extensions” tab: https://www.dropbox.com/s/qdc4bjkj9rwbgv2/2017-07-14_1459.png?dl=0

> In ”Unsupported” we have a generic link of top (it should be the same we
> used for the badge) and all the extensions there are legacy (with some of
> them being legacy and unsigned)
My point is that when setting extensions.legacy.enabled pref to false and the signatures pref xpinstall.signatures.required to true, both unsigned legacy add-on and webextension are transferred in “Unsupported” tab, so not all extensions from this tab are legacy, the unsigned webextensions are posted here too. 
As you can see in the following screenshot https://www.dropbox.com/s/a0bf4sf3gkl7tsl/2017-07-14_1620.png?dl=0 , the first extension is a webextension (Awesome Screenshot) and the second one is a legacy add-on (DownThemAll!) and there is no difference between them.  

Therefore my suggestion is that “Legacy” badge attached to legacy add-ons would make a better difference between old add-ons and webextensions in “Unsupported” tab.

Considering that in “Legacy Extensions” tabs are displayed only legacy add-ons, probably the “Legacy” label would be a bit redundant, but if the final decision of this bug is to display the “Legacy” badge for legacy add-ons from “Unsupported” tab the rule could apply also for this tab for consistency.