1380629 - In latest nightly switching to the classical theme in Windows 7 breaks user interface for Firefox

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[8a9f76+21ed5nc7zq5jk]

Attachment: classical.PNG

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20100101

Steps to reproduce:

Use the classical theme (the one that looks like Windows 2000 or earlier) in Windows 7 (instead of the default aero theme).


Actual results:

Firefox interface was broken (see included screenshots).


Expected results:

Firefox interface should not be broken.

Comment 1

[8a9f76+21ed5nc7zq5jk]

Issue does not happen with default theme for Windows 7 (see attached below).

Comment 2

[8a9f76+21ed5nc7zq5jk]

Attachment: default.PNG

Comment 3

[Johann Hofmann [:johannh]]

Might be caused by Photon work.

Comment 4

[Bill Gianopoulos [:WG9s]]

Regression window is:

Last good nightly:
20170711030203
https://hg.mozilla.org/mozilla-central/rev/0e41d07a703f19224f60b01577b2cbb5708046c9

First bad nightly:
20170712030204
https://hg.mozilla.org/mozilla-central/rev/09a4282d1172ac255038e7ccacfd772140b219e2

Comment 5

[Frank-Rainer Grahl (:frg)]

Backing out Bug 1373079 locally made it work for me again in SeaMonkey so I think it should be the same for Firefox.

Comment 6

[Johann Hofmann [:johannh]]

Not Photon-related then.

Comment 7

[Bill Gianopoulos [:WG9s]]

This actually breaks the UI so badly that in many cases it is impossible to exit Firefox because of no working menus or way to close the window.  Only way out is to use the task manager to end the process.

Comment 8

[Bill Gianopoulos [:WG9s]]

I can verify that backing out bug 1373079 fixes this for Firefox as well.

Comment 9

[Walter Chen[:ypwalter][:wachen]]

Still experiencing strange UI here when testing Hasal.

the new config onboarding hints/suggestion also broke the UI in classic theme (performance theme).

Comment 10

[jakub.g]

Attachment: nightly broken windows classic.png

FYI for me all the dialogs like "About Firefox", "Clear private data" (ctrl-shift-del) have 0 height due to this.
OTOH menu entries have width of 100% screen width (regardless of Firefox window width).

This is a pretty huge regression.

Comment 11

[Alice0775 White]

Start with -P option, as a result, profile selection dialog is completely black.
And, right click on tabbar, as a result, an empty menupopup is displayed throughout the window.

Tested Nightly56.0a1 32bit(HWA is blocked) on windows7 sp1 x64 VMWare guest.

Comment 12

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 13

[Walter Chen[:ypwalter][:wachen]]

Attachment: win7_20170717.png

This is current Nightly build. With launching of onboarding notification, the firefox would just crash and hang there. User can do nothing in that case.

The UI would still be bad with the following about:config modification, but Firefox would, at least, function okay.

"browser.onboarding.enabled": false,
"browser.onboarding.hidden": true,
"browser.onboarding.notification.finished": true

Comment 14

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1380629 - Check GetTheme result in nsNativeThemeWin

The fix for bug 1373079 neglected the detail of OpenThemeData
that it can return null if no match is found for the specified
class name. The set of matching class data sections varies with
the default and the classic theme, and the classic theme doesn't
have matches for a few of the values that we try to get. This
causes us to pass a null theme to subsequent functions, which of
course breaks the layout.

Review commit: https://reviewboard.mozilla.org/r/158028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158028/

Comment 15

[Jim Mathies [:jimm]]

Comment on attachment 8887232 [details]
Bug 1380629 - Check GetTheme result in nsNativeThemeWin

https://reviewboard.mozilla.org/r/158028/#review163888

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42880c35739e
Check GetTheme result in nsNativeThemeWin r=jimm

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

May as well track this to make sure it lands. Thanks for the quick fix!

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42880c35739e