1380665 - Define MOZ_CODE_COVERAGE for the entire tree instead of individually in several moz.build files

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Marco Castelluccio [:marco]]

We're currently adding MOZ_CODE_COVERAGE to DEFINES in several moz.build files throughout the tree, it would be better to just define it for the entire tree.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

I had to remove MOZ_CODE_COVERAGE from old-configure.in, otherwise it would have been added to config twice.

Here's a green try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6549b982544def517db9656cd4fe1c5d92ef4f20

The mozinfo.json contains correct info ("ccov" is true): https://public-artifacts.taskcluster.net/V4zpl-GWS4alC7XLuZfIXg/0/public/build/target.mozinfo.json.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8886296 [details] [diff] [review]
Patch

Review of attachment 8886296 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/32aa8aa9330b
Define MOZ_CODE_COVERAGE for the entire tree. r=jmaher

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/32aa8aa9330b