1380800 - stylo: Crash in InvalidArrayIndex_CRASH | nsTArray_Impl<T>::ElementAt | mozilla::ServoCSSRuleList::GetRule

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P1)

Description

[Andrew McCreight [:mccr8]]

This bug was filed from the Socorro interface and is 
report bp-8b2d4314-ad9d-4786-96c2-1cf430170713.
=============================================================

11 crashes from 2 installations in the last 7 days. For all of them, the array is empty, and we're trying to access element 0.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

My fault... Stupid bug...

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1380800 - Correct index check in ServoStyleSheet.deleteRule.

Review commit: https://reviewboard.mozilla.org/r/157262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157262/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8886466 [details]
Bug 1380800 - Correct index check in ServoStyleSheet.deleteRule.

https://reviewboard.mozilla.org/r/157262/#review162378

I overlooked it too when reviewing.  Thanks for the quick fix!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89603a95a868
Correct index check in ServoStyleSheet.deleteRule. r=heycam

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/89603a95a868