1380874 - Signoff UI shown on scheduled change history when signoff not required

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Screenshot

Signoffs aren't enabled for Widevine, so all the extra text on the scheduled change history page isn't necessary.

Comment 1

[[e-mail] (:bhearsum)]

We should probably remove the signoff/revoke buttons for all history, but leave the required/given signoffs for things that have them.

Comment 2

[akriti verma]

Hi, I was interested in working on this bug , but i just want to know what would be the outcome if the signoff/revoke buttons are removed. There may be other files getting affected from this change.

Comment 3

[akriti verma]

Hi Ben,
I am interested in fixing this bug ,but can you explain more about it.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to akriti verma from comment #3)
> Hi Ben,
> I am interested in fixing this bug ,but can you explain more about it.

Sorry Akriti, someone else was actually working on this but forgot to assign it. Let me know if you want a hand finding something else to work on.

Comment 5

[akriti verma]

Hi Ben ,can you help me find another bug? Thanks.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/f705320369ef6c12d499e881906fcf9936c96f1c
bug 1380874: Remove signoff/revoke buttons from history. (#392). r=bhearsum

Comment 7

[[e-mail] (:bhearsum)]

Alvin, I just realized that the Signoff/Revoke buttons have been removed, but we still show text about signoffs, eg: https://screenshots.firefox.com/XOF2Hkjc2p8gjCnQ/balrog-admin.stage.mozaws.net

Could you follow-up with a patch to remove that from the History pages, too?

Comment 8

[Alvin]

Yes, sure. I'll do a patch(In reply to Ben Hearsum (:bhearsum) from comment #7)
> Alvin, I just realized that the Signoff/Revoke buttons have been removed,
> but we still show text about signoffs, eg:
> https://screenshots.firefox.com/XOF2Hkjc2p8gjCnQ/balrog-admin.stage.mozaws.
> net
> 
> Could you follow-up with a patch to remove that from the History pages, too?

Comment 9

[[e-mail] (:bhearsum)]

The initial part of this is in production.

Comment 10

[[e-mail] (:bhearsum)]

Are you planning to finish this up, Alvin?

Comment 11

[Alvin]

Yes, I having challenges reproducing it locally though.

Comment 12

[[e-mail] (:bhearsum)]

Turns out that I can't reproduce this anymore - it must've been fixed by some other bug.

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/6c3fa23a9334100ec8804b345f23fcfeb597bae9
bug 1380874: Remove signoff text from history (#410). r=bhearsum