Closed Bug 1380909 Opened 3 years ago Closed 3 years ago

move CacheFileMetadata::GetElement out of lambda

Categories

(Core :: Networking: Cache, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Per bug 1352916 comment 20, we'd like to have a try for moving CacheFileMetadata::GetElement out of lambda.
Attached patch outOfLambda, v1Splinter Review
Attachment #8886492 - Flags: review?(michal.novotny)
Whiteboard: [necko-active]
Attachment #8886492 - Flags: review?(michal.novotny) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d90c8018a22f
Try to solve crash: move GetElement out of lambda. r=michal
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d90c8018a22f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment on attachment 8886492 [details] [diff] [review]
outOfLambda, v1

Approval Request Comment
[Feature/Bug causing the regression]:Bug 1325088
[User impact if declined]:Crash, 3-15 crashes per day in beta now
[Is this code covered by automated tests?]:No
[Has the fix been verified in Nightly?]:Yes, no such crash happen after this bug
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]:almost no risk
[Why is the change risky/not risky?]:small logic change in code
[String changes made/needed]:no
Attachment #8886492 - Flags: approval-mozilla-beta?
Duplicate of this bug: 1352916
Comment on attachment 8886492 [details] [diff] [review]
outOfLambda, v1

crash fix for beta55

it's closer to 100 crashes a day than 3-15...  Should be in 55.0b11
Attachment #8886492 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Junior[:junior] from comment #5)
> [Is this code covered by automated tests?]:No
> [Has the fix been verified in Nightly?]:Yes, no such crash happen after this
> bug
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Junior's assessment on manual testing needs.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.