1380948 - Resolve possible issues in bookmark properties dialogs with potential for undoing an action whilst part way through a transaction

Status: RESOLVED INVALID

(Toolkit :: Places, enhancement, P3)

Description

[Mark Banner (:standard8)]

From bug 1378711:

> The only negative aspect left is that this is only a partial solution, if
> the dialog is awaiting on something that is not a transaction (maybe even
> just a promiseItemId) before actually starting a transaction, this won't
> catch it.
> 
> As previously discussed, I fear the only real solutions to the problem are:
> 1. have in editBookmarkOverlay an array of all the pending promises, and in
> both bookmarkProperties and browser-places wait on that and on eventual
> local promises. It would basically be a Promise.all([_batchBlockingDeferred,
> pendingPromises]). It may require quite some refactoring. We'd collect the
> array of promises only when batching (we could pass an array to initPanel to
> push promises to) and clear it when the batch is done.
> 2. stop having these dialogs instant apply, and instead just collect
> transactions in an array and pass that to batch, that is the proper way to
> use it. Unfortunately this may be even more complex, and I wonder how we'd
> handle things like creating and visualizing a new folder in the folders tree.

Comment 1

[Marco Bonardo [:mak]]

it's unclear how much this is a real world problem, so not blocking for now.

Comment 2

[Marco Bonardo [:mak]]

Regardless, the best thing would probably be to make these dialogs non instant-apply. But that's a large effort involving UX.

Comment 3

[Marco Bonardo [:mak]]

the dialog is no longer instant apply, so this shouldn't apply anymore.