1381008 - Identity block hover background slightly overlaps the border on Mac

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Johann Hofmann [:johannh]]

Attachment: screenshot

See screenshot. It's quite visible to me, even zoomed out. I don't think this is happening on other platforms.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1381008 - Dont enlarge identify box while inactive.

Review commit: https://reviewboard.mozilla.org/r/163476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163476/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8892493 [details]
Bug 1381008 - Dont enlarge identify box while inactive.

https://reviewboard.mozilla.org/r/163476/#review168846

::: browser/themes/osx/browser.css:649
(Diff revision 1)
>  #urlbar:not([focused="true"]) > #identity-box {
>    margin-top: -1px;
>    margin-bottom: -1px;
>    padding-top: 3px;
>    padding-bottom: 3px;
>  }

Is this still needed? Windows and Linux don't have it and the styling should be consistent across platforms, right? The focus ring is slightly different on Mac but I don't see how this would make a difference here.

Comment 3

[Dale Harvey (:daleharvey)]

> Is this still needed? Windows and Linux don't have it and the styling 
> should be consistent across platforms, right? The focus ring is slightly 
> different on Mac but I don't see how this would make a difference here.

I don't think so, I generally err on the side of touching as few things as possible, not sure what this was for but doesnt look to be needed any more

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8892493 [details]
Bug 1381008 - Dont enlarge identify box while inactive.

https://reviewboard.mozilla.org/r/163476/#review168872

Okay, please get rid of that rule.

::: browser/themes/osx/browser.css:642
(Diff revision 1)
>  %include ../shared/identity-block/identity-block.inc.css
>  
>  #identity-box {
>    padding-top: 2px;
>    padding-bottom: 2px;
>  }

Should also check if this is still needed.

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8892493 [details]
Bug 1381008 - Dont enlarge identify box while inactive.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163476/diff/1-2/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8892493 [details]
Bug 1381008 - Dont enlarge identify box while inactive.

https://reviewboard.mozilla.org/r/163476/#review169138

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54f838a5c2e1
Dont enlarge identify box while inactive. r=dao

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54f838a5c2e1

Comment 9

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=52285ea5e54c73d3ed824544cef2ee3f195f05e6&newProject=mozilla-central&newRev=4c7317211990d6cf156c103a73a5b3ec41f2dd4d&filter=%5Eosx.*controlCenter

Comment 10

[ovidiu boca[:Ovidiu]]

I verified this on Mac OS X 10.10 with Nightly 57.0a1(2017-08-18) and I can confirm the fix.
I also have a question: When I hover the mouse over "Nightly" from the URL bar (Entity Lable) this becomes grayer, from #FFFFFF to #F2F2F2, this is the intended color? From my point of view, I think this action should be more visible. 

I will mark this as verified fixed, based on the fact that the initial issue is no longer reproducible.

Comment 11

[Dale Harvey (:daleharvey)]

Yup it is intented to be a subtle hover change, thanks