Closed
Bug 1381058
Opened 7 years ago
Closed 7 years ago
Report which store buffer fills up for FULL_STORE_BUFFER minor GCs
Categories
(Core :: JavaScript: GC, enhancement)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: sfink, Assigned: jonco)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
11.40 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
The store buffer is actually a collection of individual store buffers, and it's helpful to know which one filled up. We should report that in whatever ways make sense -- in the profile JSON (maybe exact counts for each buffer here), maybe in telemetry, in the stdout-style logging, ...?
|
Assignee | |
Comment 1•7 years ago
|
||
Split the store buffer full reason code into a separate one for each buffer.
Assignee: nobody → jcoppeard
Attachment #8886648 -
Flags: review?(sphink)
|
Reporter | |
Comment 2•7 years ago
|
||
Comment on attachment 8886648 [details] [diff] [review] bug1381058-split-full-store-buffer-reasons Review of attachment 8886648 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8886648 -
Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d1a13d4e94f Split full store buffer reasons into a separate reason for each store buffer r=sfink
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4d1a13d4e94f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•