Identity icon should have a darker hover state

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
a month ago
7 days ago

People

(Reporter: johannh, Assigned: dao)

Tracking

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed, firefox57 verified)

Details

(Whiteboard: [photon-visual][p2])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

According to the interactive mockup (http://design.firefox.com/people/shorlander/photon/Mockups/macOS.html) the identity icon should get a little darker when hovering the identity block. It currently does not, at least on my machine.
Comment hidden (mozreview-request)
(Assignee)

Updated

a month ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: qe-verify+
OS: Unspecified → All
Priority: -- → P1
Hardware: Unspecified → All
Whiteboard: [photon-visual][triage] → [photon-visual][p2]
Comment hidden (mozreview-request)

Updated

a month ago
Iteration: --- → 56.3 - Jul 24
QA Contact: brindusa.tot
(Reporter)

Comment 3

a month ago
mozreview-review
Comment on attachment 8886789 [details]
Bug 1381117 - Increase opacity of icons in the identity block on hover.

https://reviewboard.mozilla.org/r/157578/#review162846

::: browser/themes/shared/identity-block/connection-mixed-active-loaded.svg:1
(Diff revision 2)
>  <?xml version="1.0" encoding="utf-8"?>

You can remove the xml declarations.
Attachment #8886789 - Flags: review?(jhofmann) → review-
Sorry, the r- was not because of the xml declarations, but rather because the notification icons are not colored correctly, you probably need to add context-fill-opacity here:

https://searchfox.org/mozilla-central/source/browser/themes/shared/notification-icons.svg#4

mozreview was crashing on me
(Assignee)

Comment 5

a month ago
(In reply to Johann Hofmann [:johannh] from comment #3)
> Comment on attachment 8886789 [details]
> Bug 1381117 - Increase opacity of icons in the identity block on hover.
> 
> https://reviewboard.mozilla.org/r/157578/#review162846
> 
> ::: browser/themes/shared/identity-block/connection-mixed-active-loaded.svg:1
> (Diff revision 2)
> >  <?xml version="1.0" encoding="utf-8"?>
> 
> You can remove the xml declarations.

I'll leave that for another bug. Doing one drive-by cleanup doesn't mean all of it should happen here. ;)
Comment hidden (mozreview-request)
(Reporter)

Comment 7

a month ago
mozreview-review
Comment on attachment 8886789 [details]
Bug 1381117 - Increase opacity of icons in the identity block on hover.

https://reviewboard.mozilla.org/r/157578/#review163384

Looks good, thanks.
Attachment #8886789 - Flags: review?(jhofmann) → review+

Comment 8

a month ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d43602ea02ec
Increase opacity of icons in the identity block on hover. r=johannh

Comment 9

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d43602ea02ec
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
This bug seemed to be about the identity block but also changed the icon darkness within the control center panel, was that intentional?

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=5e73b9798464c3f7106f0161dc9a49b234f42f9c&newProject=mozilla-central&newRev=8ff4f17b266db9a780efe06f7fbdae629e49f5bc&filter=controlCenter
(Assignee)

Comment 11

a month ago
(In reply to Matthew N. [:MattN] (huge backlog; PM if requests are blocking you) from comment #10)
> This bug seemed to be about the identity block but also changed the icon
> darkness within the control center panel, was that intentional?
> 
> https://screenshots.mattn.ca/compare/?oldProject=mozilla-
> central&oldRev=5e73b9798464c3f7106f0161dc9a49b234f42f9c&newProject=mozilla-
> central&newRev=8ff4f17b266db9a780efe06f7fbdae629e49f5bc&filter=controlCenter

Yes, updated for consistency.
QA Contact: brindusa.tot → ovidiu.boca

Comment 12

7 days ago
Verified on Windows 10 x 64 and MAC OSX 10.12.5 on latest Nightly 57.0a1. Increased the opacity of icons in the identity block on hover.Looks good. Marked as verified fixed. Thank you
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.