Closed
Bug 1381137
Opened 7 years ago
Closed 7 years ago
stylo: "Declaration dropped"/"Skipped to next declaration" missing from parser error messages
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: jdm, Assigned: jdm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.60 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
Stylo's CSS error reporting is missing the followup messages that Gecko provides, such as for "display: invalid".
Fixing this makes it slightly simpler to manage a few DevTools tests happen to check exact strings of CSS errors. We could also instead change those tests if we don't get around to this in time.
Blocks: stylo-devtools-tests
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → josh
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8890105 -
Flags: review?(cam)
Assignee | ||
Comment 3•7 years ago
|
||
The Servo-side changes are in https://github.com/servo/servo/pull/17859.
Comment 4•7 years ago
|
||
Comment on attachment 8890105 [details] [diff] [review] Append skipped/dropped message to Stylo CSS error reports Review of attachment 8890105 [details] [diff] [review]: ----------------------------------------------------------------- (In future, if you could attach patches with 8 lines of context, that should make it easier for me to review. Even better if you use mozreview, since I can expand the context myself!) ::: layout/style/ServoBindings.cpp @@ +2678,5 @@ > nsAutoString wideParam = NS_ConvertUTF8toUTF16(paramValue); > reporter->ReportUnexpectedUnescaped(message, wideParam); > + if (followup) { > + reporter->ReportUnexpected(followup); > + } This is OK, although there are some cases where Gecko will report three errors before calling OutputError, such as here: http://searchfox.org/mozilla-central/rev/8a61c71153a79cda2e1ae7d477564347c607cc5f/layout/style/nsCSSParser.cpp#1978-1986 (Whether any > 2 message cases will come up in the error messages you are trying to match on I'm not sure. Maybe maximum 2 is good enough.)
Attachment #8890105 -
Flags: review?(cam) → review+
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/5a8e20149490 Append skipped/dropped message to Stylo CSS error reports. r=heycam
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5a8e20149490
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•