Closed
Bug 1381141
Opened 5 years ago
Closed 5 years ago
Implement PaymentRequest UI stubs
Categories
(Firefox :: WebPayments UI, enhancement)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: MattN, Assigned: jonathanGB)
References
()
Details
Attachments
(1 file)
Implement a stub/boilerplate for the PaymentRequest UI.
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 2•5 years ago
|
||
| mozreview-review | ||
Comment on attachment 8886706 [details] Bug 1381141 - Implement PaymentRequest UI stubs. https://reviewboard.mozilla.org/r/157496/#review162638 Thanks
Attachment #8886706 -
Flags: review?(MattN+bmo) → review+
|
Assignee | |
Comment 3•5 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8886706 [details] Bug 1381141 - Implement PaymentRequest UI stubs. https://reviewboard.mozilla.org/r/157496/#review162638 It's a pleasure
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/23327a999975 Implement PaymentRequest UI stubs. r=MattN
Backed out for opt/pgo bc failures like https://treeherder.mozilla.org/logviewer.html#?job_id=114532171&repo=autoland https://hg.mozilla.org/integration/autoland/rev/b2f96b5732866466d82138c67ff72bda0e040243
Flags: needinfo?(jguillotteblouin)
| Comment hidden (mozreview-request) |
|
||
Comment 11•5 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/4f577bce4a5d Implement PaymentRequest UI stubs. r=MattN
|
|
Assignee | |
Comment 12•5 years ago
|
||
whitelisted in latest commit "chrome://payments/content/paymentRequest.xhtml" while we're building the WebPayments UI
Flags: needinfo?(jguillotteblouin)
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4f577bce4a5d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox56:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Comment 14•5 years ago
|
||
I think this breaks builds when RELEASE_OR_BETA is set and NIGHTLY_BUILD is not set. See https://treeherder.mozilla.org/#/jobs?repo=jamun&selectedJob=115714348 - a jamun build which is used to test 56.b1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 15•5 years ago
|
||
Yeah, I backed out the patch from jamun and it worked https://treeherder.mozilla.org/#/jobs?repo=jamun&revision=7cd20e9e0047ebb7e0a4eb546c061a16693641e0
|
|
Assignee | |
Comment 16•5 years ago
|
||
(In reply to Rail Aliiev [:rail] ⌚️ET - PTO in August from comment #15) > Yeah, I backed out the patch from jamun and it worked > https://treeherder.mozilla.org/#/ > jobs?repo=jamun&revision=7cd20e9e0047ebb7e0a4eb546c061a16693641e0 Going to put back this bug as "resolved", will apply changes in the follow-up patch (Bug 1382839).
|
|
Assignee | |
Updated•5 years ago
|
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Resolution: --- → FIXED
|
|
||
Comment 17•5 years ago
|
||
Thank you.
|
|
Reporter | |
Updated•5 years ago
|
Component: General → WebPayments UI
|
||
Updated•4 years ago
|
Product: Toolkit → Firefox
Target Milestone: mozilla56 → Firefox 56
You need to log in
before you can comment on or make changes to this bug.
Description
•