1381141 - Implement PaymentRequest UI stubs

Status: RESOLVED FIXED

(Firefox :: WebPayments UI, enhancement)

Description

[Matthew N. [:MattN]]

Implement a stub/boilerplate for the PaymentRequest UI.

Comment 1

[Jonathan Guillotte-Blouin [:jonathanGB]]

Attachment: Bug 1381141 - Implement PaymentRequest UI stubs.

Review commit: https://reviewboard.mozilla.org/r/157496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157496/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8886706 [details]
Bug 1381141 - Implement PaymentRequest UI stubs.

https://reviewboard.mozilla.org/r/157496/#review162638

Thanks

Comment 3

[Jonathan Guillotte-Blouin [:jonathanGB]]

Comment on attachment 8886706 [details]
Bug 1381141 - Implement PaymentRequest UI stubs.

https://reviewboard.mozilla.org/r/157496/#review162638

It's a pleasure

Comment 4

[Jonathan Guillotte-Blouin [:jonathanGB]]

Comment on attachment 8886706 [details]
Bug 1381141 - Implement PaymentRequest UI stubs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157496/diff/1-2/

Comment 5

[Jonathan Guillotte-Blouin [:jonathanGB]]

Comment on attachment 8886706 [details]
Bug 1381141 - Implement PaymentRequest UI stubs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157496/diff/2-3/

Comment 6

[Jonathan Guillotte-Blouin [:jonathanGB]]

Comment on attachment 8886706 [details]
Bug 1381141 - Implement PaymentRequest UI stubs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157496/diff/3-4/

Comment 7

[Jonathan Guillotte-Blouin [:jonathanGB]]

Comment on attachment 8886706 [details]
Bug 1381141 - Implement PaymentRequest UI stubs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157496/diff/4-5/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23327a999975
Implement PaymentRequest UI stubs. r=MattN

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for opt/pgo bc failures like  https://treeherder.mozilla.org/logviewer.html#?job_id=114532171&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/b2f96b5732866466d82138c67ff72bda0e040243

Comment 10

[Jonathan Guillotte-Blouin [:jonathanGB]]

Comment on attachment 8886706 [details]
Bug 1381141 - Implement PaymentRequest UI stubs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157496/diff/5-6/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f577bce4a5d
Implement PaymentRequest UI stubs. r=MattN

Comment 12

[Jonathan Guillotte-Blouin [:jonathanGB]]

whitelisted in latest commit "chrome://payments/content/paymentRequest.xhtml" while we're building the WebPayments UI

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4f577bce4a5d

Comment 14

[Rail Aliiev [:rail]]

I think this breaks builds when RELEASE_OR_BETA is set and NIGHTLY_BUILD is not set. See https://treeherder.mozilla.org/#/jobs?repo=jamun&selectedJob=115714348 - a jamun build which is used to test 56.b1

Comment 15

[Rail Aliiev [:rail]]

Yeah, I backed out the patch from jamun and it worked https://treeherder.mozilla.org/#/jobs?repo=jamun&revision=7cd20e9e0047ebb7e0a4eb546c061a16693641e0

Comment 16

[Jonathan Guillotte-Blouin [:jonathanGB]]

(In reply to Rail Aliiev [:rail] ⌚️ET - PTO in August from comment #15)
> Yeah, I backed out the patch from jamun and it worked
> https://treeherder.mozilla.org/#/
> jobs?repo=jamun&revision=7cd20e9e0047ebb7e0a4eb546c061a16693641e0

Going to put back this bug as "resolved", will apply changes in the follow-up patch (Bug 1382839).

Comment 17

[Rail Aliiev [:rail]]

Thank you.