Closed Bug 1381240 Opened 7 years ago Closed 7 years ago

Crash in @0x0 | mozilla::plugins::BrowserStreamParent::RecvNPN_DestroyStream

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
Unspecified
Windows 10
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox54 --- unaffected
firefox55 --- unaffected
firefox56 --- fixed

People

(Reporter: marcia, Assigned: dan1bh)

References

Details

(Keywords: crash, regression)

Crash Data

This bug was filed from the Socorro interface and is 
report bp-e06d137b-ea4a-4b45-9d0b-f3f680170715.
=============================================================

Spike seen in 20170714030205: http://bit.ly/2uux4ru - 944 crashes in 282 installations.

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=30ea2905130e85f9e1d8d56fa3097901eec6514b&tochange=67cd1ee26f2661fa5efe3d952485ab3c89af4271

ni on bsmedberg in case it is Bug 1352559
Flags: needinfo?(benjamin)
Adding Mac version of signature: @0x0 | mozilla::plugins::PBrowserStreamParent::OnMessageReceived
Crash Signature: [@ @0x0 | mozilla::plugins::BrowserStreamParent::RecvNPN_DestroyStream] → [@ @0x0 | mozilla::plugins::BrowserStreamParent::RecvNPN_DestroyStream] [@ @0x0 | mozilla::plugins::PBrowserStreamParent::OnMessageReceived]
In the Nightly 20170714100217 build this is the #1 topcrash on Windows and Mac (even above ShutdownKill) and #2 on Linux.

I'm 99% certain that part 3 of bug 1352559 is the cause. We are crashing with a null pointer on this line:

> mNPP->mNPNIface->destroystream(mNPP->mNPP, mStream, reason);

And that patch changed sBrowserFuncs.destroystream to nullptr. Maybe there's a missing null check?
Flags: needinfo?(dan1bh)
Depends on: 1352559
I backed out part 3 of bug 1352559 from mozilla-central.
Thank you. I'll close this FIXED and look into what's causing bug 1352559. It's supposed to be that nobody is calling this API any more, but clearly that's not true in practice.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(benjamin)
Resolution: --- → FIXED
Assignee: nobody → dan1bh
status-firefox54: --- → unaffected
status-firefox55: --- → unaffected
status-firefox56: affected → fixed
status-firefox-esr52: --- → unaffected
Flags: needinfo?(dan1bh)
Target Milestone: --- → mozilla56
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.