Closed
Bug 1381253
Opened 8 years ago
Closed 8 years ago
Remove redundant control flow declarations
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox56 fixed)
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
80.83 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
like return; at the end of a void function or continue; at the end of the loop
http://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-control-flow.html
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sledru
Assignee | ||
Updated•8 years ago
|
Attachment #8886798 -
Flags: review?(ehsan)
Comment 3•8 years ago
|
||
Comment on attachment 8886798 [details] [diff] [review]
bug-continue-return.diff
Review of attachment 8886798 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me
Attachment #8886798 -
Flags: review?(ehsan) → review+
Assignee | ||
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d72854694b360ce5051f37256518c3b3a8e69237
Bug 1381253 - Remove redundant control flow declarations rs=ehsan
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d72854694b36
Remove redundant control flow declarations rs=ehsan
![]() |
||
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•8 years ago
|
status-firefox57:
affected → ---
Assignee | ||
Updated•8 years ago
|
Blocks: clang-based-analysis
Updated•7 years ago
|
Product: Core → Firefox Build System
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•