|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Instead of showing "Video format or MIME type is not supported" when the source is unreachable which is a bit misleading, we should consider a specific error message for not found error. As 1376004 will be landed soon, we'll get more informative error message from playback, and that would be something we can respect for the message on UI.
Hi Stephen, Could you provide me some ideas about what to show on video control when the media source is not found? I was thinking something like "Video source is not found", but I guess it's not interpretive enough for users. Thanks
Redirecting to Michelle since she is doing more of the writing for Firefox.
Flags: needinfo?(shorlander) → needinfo?(mheubusch)
11 months ago
Priority: -- → P4
Let's go with "Video not found" since the word "source" is a bit technical. Ralin, can you take this?
Flags: needinfo?(mheubusch) → needinfo?(ralin)
Sure, I have some spare time tomorrow, I'll work on it. Thanks.
Assignee: nobody → ralin
Ray, Do you think we can show the error in Bug 1411766 on the video control?
Bug 708150 addressed very similar issue. The discussions look solid to me as yet, so I didn't create new string for this.
Comment on attachment 8923281 [details] Bug 1381375 - Show proper error message for 404 not found media source on video controls. https://reviewboard.mozilla.org/r/194466/#review199682 ::: toolkit/content/widgets/videocontrols.xml:769 (Diff revision 1) > break; > case v.error.MEDIA_ERR_DECODE: > error = "errorDecode"; > break; > case v.error.MEDIA_ERR_SRC_NOT_SUPPORTED: > - error = "errorSrcNotSupported"; > + error = v.networkState == v.NETWORK_NO_SOURCE ? "errorNoSource" : "errorSrcNotSupported"; Can you wrap this a new line at the ? mark? ``` error = v.networkState == v.NETWORK_NO_SOURCE ? "errorNoSource" : "errorSrcNotSupported"; break; ```
Attachment #8923281 - Flags: review?(jaws) → review+
Issue fixed, thanks for review :D
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/5599898d9bad Show proper error message for 404 not found media source on video controls. r=jaws
Backout by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a16cc603d061 Backed out changeset 5599898d9bad for failures in test_videocontrols_error.html
Wups, little slow on the copy-paste here, "for failures in test_videocontrols_error.html like https://treeherder.mozilla.org/logviewer.html#?job_id=140955251&repo=autoland"
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/56717feaa049 Show proper error message for 404 not found media source on video controls. r=jaws
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
8 failures in 857 pushes (0.009 failures/push) were associated with this bug in the last 7 days. Repository breakdown: * autoland: 8 Platform breakdown: * android-7-1-armv8-api16: 4 * android-6-0-armv8-api16: 4 For more details, see: https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1381375&startday=2017-10-30&endday=2017-11-05&tree=all
You need to log in before you can comment on or make changes to this bug.