Show proper error on video controls when the media source is not found (getting 404 response code)

RESOLVED FIXED in Firefox 58

Status

()

P4
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: ralin, Assigned: ralin)

Tracking

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Instead of showing "Video format or MIME type is not supported" when the source is unreachable which is a bit misleading, we should consider a specific error message for not found error. As 1376004 will be landed soon, we'll get more informative error message from playback, and that would be something we can respect for the message on UI.
(Assignee)

Comment 1

a year ago
Hi Stephen, 


Could you provide me some ideas about what to show on video control when the media source is not found? I was thinking something like "Video source is not found", but I guess it's not interpretive enough for users.

Thanks
Flags: needinfo?(shorlander)
Redirecting to Michelle since she is doing more of the writing for Firefox.
Flags: needinfo?(shorlander) → needinfo?(mheubusch)
Let's go with "Video not found" since the word "source" is a bit technical. Ralin, can you take this?
Flags: needinfo?(mheubusch) → needinfo?(ralin)
(Assignee)

Comment 4

10 months ago
Sure, I have some spare time tomorrow, I'll work on it. Thanks.
Assignee: nobody → ralin
Flags: needinfo?(ralin)
(Assignee)

Updated

10 months ago
Depends on: 1412251
Ray, 
Do you think we can show the error in Bug 1411766 on the video control?
Comment hidden (mozreview-request)
(Assignee)

Comment 7

10 months ago
Bug 708150 addressed very similar issue. The discussions look solid to me as yet, so I didn't create new string for this.
(Assignee)

Updated

10 months ago
Status: NEW → ASSIGNED
Comment on attachment 8923281 [details]
Bug 1381375 - Show proper error message for 404 not found media source on video controls.

https://reviewboard.mozilla.org/r/194466/#review199682

::: toolkit/content/widgets/videocontrols.xml:769
(Diff revision 1)
>                break;
>              case v.error.MEDIA_ERR_DECODE:
>                error = "errorDecode";
>                break;
>              case v.error.MEDIA_ERR_SRC_NOT_SUPPORTED:
> -              error = "errorSrcNotSupported";
> +              error = v.networkState == v.NETWORK_NO_SOURCE ? "errorNoSource" : "errorSrcNotSupported";

Can you wrap this a new line at the ? mark?

```
error = v.networkState == v.NETWORK_NO_SOURCE ?
  "errorNoSource" :
  "errorSrcNotSupported";
break;
```
Attachment #8923281 - Flags: review?(jaws) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 10

10 months ago
Issue fixed, thanks for review :D
Keywords: checkin-needed

Comment 11

10 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5599898d9bad
Show proper error message for 404 not found media source on video controls. r=jaws
Keywords: checkin-needed

Comment 12

10 months ago
Backout by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a16cc603d061
Backed out changeset 5599898d9bad for failures in test_videocontrols_error.html
Wups, little slow on the copy-paste here, "for failures in test_videocontrols_error.html like https://treeherder.mozilla.org/logviewer.html#?job_id=140955251&repo=autoland"
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Keywords: checkin-needed

Comment 15

10 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/56717feaa049
Show proper error message for 404 not found media source on video controls. r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/56717feaa049
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
8 failures in 857 pushes (0.009 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 8

Platform breakdown:
* android-7-1-armv8-api16: 4
* android-6-0-armv8-api16: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1381375&startday=2017-10-30&endday=2017-11-05&tree=all
You need to log in before you can comment on or make changes to this bug.