1381375 - Show proper error on video controls when the media source is not found (getting 404 response code)

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P4)

Description

[Ray Lin[:ralin]]

Instead of showing "Video format or MIME type is not supported" when the source is unreachable which is a bit misleading, we should consider a specific error message for not found error. As 1376004 will be landed soon, we'll get more informative error message from playback, and that would be something we can respect for the message on UI.

Comment 1

[Ray Lin[:ralin]]

Hi Stephen, 


Could you provide me some ideas about what to show on video control when the media source is not found? I was thinking something like "Video source is not found", but I guess it's not interpretive enough for users.

Thanks

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Redirecting to Michelle since she is doing more of the writing for Firefox.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Let's go with "Video not found" since the word "source" is a bit technical. Ralin, can you take this?

Comment 4

[Ray Lin[:ralin]]

Sure, I have some spare time tomorrow, I'll work on it. Thanks.

Comment 5

[Blake Wu [:bwu][:blakewu]]

Ray, 
Do you think we can show the error in Bug 1411766 on the video control?

Comment 6

[Ray Lin[:ralin]]

Attachment: Bug 1381375 - Show proper error message for 404 not found media source on video controls.

Review commit: https://reviewboard.mozilla.org/r/194466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194466/

Comment 7

[Ray Lin[:ralin]]

Bug 708150 addressed very similar issue. The discussions look solid to me as yet, so I didn't create new string for this.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8923281 [details]
Bug 1381375 - Show proper error message for 404 not found media source on video controls.

https://reviewboard.mozilla.org/r/194466/#review199682

::: toolkit/content/widgets/videocontrols.xml:769
(Diff revision 1)
>                break;
>              case v.error.MEDIA_ERR_DECODE:
>                error = "errorDecode";
>                break;
>              case v.error.MEDIA_ERR_SRC_NOT_SUPPORTED:
> -              error = "errorSrcNotSupported";
> +              error = v.networkState == v.NETWORK_NO_SOURCE ? "errorNoSource" : "errorSrcNotSupported";

Can you wrap this a new line at the ? mark?

```
error = v.networkState == v.NETWORK_NO_SOURCE ?
  "errorNoSource" :
  "errorSrcNotSupported";
break;
```

Comment 9

[Ray Lin[:ralin]]

Comment on attachment 8923281 [details]
Bug 1381375 - Show proper error message for 404 not found media source on video controls.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194466/diff/1-2/

Comment 10

[Ray Lin[:ralin]]

Issue fixed, thanks for review :D

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5599898d9bad
Show proper error message for 404 not found media source on video controls. r=jaws

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a16cc603d061
Backed out changeset 5599898d9bad for failures in test_videocontrols_error.html

Comment 13

[Phil Ringnalda (:philor)]

Wups, little slow on the copy-paste here, "for failures in test_videocontrols_error.html like https://treeherder.mozilla.org/logviewer.html#?job_id=140955251&repo=autoland"

Comment 14

[Ray Lin[:ralin]]

Comment on attachment 8923281 [details]
Bug 1381375 - Show proper error message for 404 not found media source on video controls.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194466/diff/2-3/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56717feaa049
Show proper error message for 404 not found media source on video controls. r=jaws

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/56717feaa049

Comment 17

[Intermittent Failures Robot]

8 failures in 857 pushes (0.009 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 8

Platform breakdown:
* android-7-1-armv8-api16: 4
* android-6-0-armv8-api16: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1381375&startday=2017-10-30&endday=2017-11-05&tree=all