Closed Bug 1381383 Opened 8 years ago Closed 1 year ago

facebook_ail_click_photo_viewer_right_arrow is too slow

Categories

(Core :: CSS Parsing and Computation, defect, P3)

56 Branch
x86_64
Windows 10
defect

Tracking

()

RESOLVED WORKSFORME
Performance Impact low
Tracking Status
firefox57 --- wontfix

People

(Reporter: myen, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [QRC][QRC_Analyzed])

Attachments

(1 file)

STR: 0. Logged in with Whitehat account, go to Linda's photo album 1. Click right-arrow button on photo to next photo Short Gecko Profile(cover only Input Lantency action): https://perfht.ml/2tZOHOE on Ref Device Reports: https://goo.gl/DjIwNb Notes: https://docs.google.com/spreadsheets/d/1RgiyTm41Af-mC0lVkqiDT1sp9yKNkZ5cBoj7bApZWtY/edit?ts=596c1cbc#gid=256706414
Whiteboard: [QRC][QRC_Analyzed]
Whiteboard: [QRC][QRC_Analyzed] → [QRC][QRC_NeedAnalysis]
Paul, could you help to have the first analysis? Thanks.
Assignee: nobody → padenot
Flags: needinfo?(padenot)
Bobby, what are the details for this account?
Flags: needinfo?(padenot) → needinfo?(bchien)
Mark, please help Paul to access Hasal whitehat account. thanks. Paul, Facebook provides whitehat account in each FB account. You could either use your own whitehat, or use Hasal whitehat. The differences are the contents, like news feed, etc. Please ask Mark anyting you need in measurement and profiling. Thanks.
Flags: needinfo?(bchien) → needinfo?(myen)
(In reply to Paul Adenot (:padenot) from comment #2) > Bobby, what are the details for this account? What details would you like to know more about?
Flags: needinfo?(myen)
Well, the login/passwd or whatever I need to have a look at the page and guess what is happening here.
Flags: needinfo?(myen)
Files contain the video recordings of Facebook photoviewer test case on window10.
Flags: needinfo?(myen)
(In reply to Paul Adenot (:padenot) from comment #5) > Well, the login/passwd or whatever I need to have a look at the page and > guess what is happening here. I have uploaded recordings of this testing case. You can check the steps and account details in the video. However, the videos were not recorded on the exact same reference device, so there might be some differences. But it still provides you with a insight of our test case, since the account and steps are the same.
What I see is a bunch of js code being executed in the child. I'm not expert, but it looks like we interpret some of it, and it runs off a mousemove event. This seem to spam the parent, the parent its therefore less responsive. Where do we go from here ?
Flags: needinfo?(myen)
(In reply to Paul Adenot (:padenot) from comment #8) > What I see is a bunch of js code being executed in the child. I'm not > expert, but it looks like we interpret some of it, and it runs off a > mousemove event. This seem to spam the parent, the parent its therefore less > responsive. > > Where do we go from here ? What if we check whether there are any unnecessary events and remove them? Will it help solve this situation.
Flags: needinfo?(myen)
Component: JavaScript Engine → General
(In reply to myen from comment #9) > (In reply to Paul Adenot (:padenot) from comment #8) > > What I see is a bunch of js code being executed in the child. I'm not > > expert, but it looks like we interpret some of it, and it runs off a > > mousemove event. This seem to spam the parent, the parent its therefore less > > responsive. > > > > Where do we go from here ? > > What if we check whether there are any unnecessary events and remove them? > Will it help solve this situation. This is probably not web-compatible.
Sean, could you help to follow profile analysis from Paul? Thanks.
Assignee: padenot → sstangl
Component: General → JavaScript Engine
Flags: needinfo?(sstangl)
Depends on: 1388179
Change component to Layout per depends bug 1388179.
Component: JavaScript Engine → Layout
Summary: facebook_ail_click_photo_viewer_right_arrow for QRC_NeedAnalysis → facebook_ail_click_photo_viewer_right_arrow
Whiteboard: [QRC][QRC_NeedAnalysis] → [qf][QRC][QRC_Analyzed]
Whiteboard: [qf][QRC][QRC_Analyzed] → [qf:p3][QRC][QRC_Analyzed]
Priority: -- → P3
Keywords: perf
(In reply to Bobby Chien from comment #12) > Change component to Layout per depends bug 1388179. That bug's looking like it's mostly a style-system issue (per bug 1388179 comment 4), so bumping this to CSS.
Component: Layout → CSS Parsing and Computation
Depends on: 1424057
Summary: facebook_ail_click_photo_viewer_right_arrow → facebook_ail_click_photo_viewer_right_arrow is too slow
Performance Impact: --- → P3
Whiteboard: [qf:p3][QRC][QRC_Analyzed] → [QRC][QRC_Analyzed]

The bug assignee didn't login in Bugzilla in the last 7 months.
:emilio, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: sstangl → nobody
Flags: needinfo?(emilio)

This would need new profiles and repro steps.

Flags: needinfo?(emilio)
Flags: needinfo?(sstangl)
Severity: normal → S3

Should this bug be closed?

All dependencies are closed, and looks like the website code has changed.
I will close this bug, but Please reopen if needed.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: