1381564 - Trigger restart in private loose all non-private tabs

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[nailyk]

Attachment: foo.mp4

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170613225334

Steps to reproduce:

1. Open firefox, your session is restored. 
2. Open a private navigate windows, browse something, 
3. In the private windows open addons option, 
4. Update/enable/disable an addon to trigger the 'restart now' button, 
5. Hit restart. 

Tested on (linux 64): 
- ESR 48
- ESR 52
- nightly 51.0a

Could be a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=772141


Actual results:

Firefox open in non private mode and all saved tabs are lost. 


Expected results:

Opened tabs are restored.

Comment 1

[Andrew Swan [:aswan]]

I'm not all that familiar with session restore but it looks like this is by design.  If I leave the add-ons manager out of the steps (ie just open some private tabs then restart the browser) I see the same thing.
The session restore maintainers can confirm that and close this though...

Comment 2

[nailyk]

Not sure how do you restart browser. 
1. Open browser, 
2. open private windows, 
3. close 'not-private' firefox, 
4. close private firefox, 
5. Open firefox again
- All your tabs are here.

Comment 3

[nailyk]

Correction, 1th tab is lost on nightly. (Dunno how to add an attachment into comment)
https://claude.nailyk.fr/index.php/s/gT0tOiak850KLUS

Comment 4

[nailyk]

On both ESR52 and nightly 1st tab is keep: https://claude.nailyk.fr/index.php/s/nKuUEzVXRGUns85 . Probably a bad click on my side on the previous record. 
But regarding issue, here, all tabs are still here.This is not the case when restart is triggered while a plugin get updated, for example. I don't know other ways to restart firefox.