1381567 - Weekly close of inactive Intermittent bugs without sending mails

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Administration, task)

Description

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Please resolve as incomplete the bugs in this query using the close w/o sending mail script.

https://mzl.la/2szfdLn

It'd be most excellent if this was run weekly on Mondays.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

If we want to run resolve_bugs.pl from a cronjob (very possible)

we just need to make sure https://github.com/mozilla-bteam/bmo/blob/master/scripts/resolve_bugs.pl#L59-L66
is wrapped in if (-t STDIN) { }

That will prevent prompting when STDIN isn't a terminal.

Comment 2

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: GitHub pull request

I was not sure what to do with the heredoc style. 

Gabor Szabo suggests using q or qq when you need to wrap a heredoc in a conditional, but it feels like overkill.

Comment 3

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Oh, Gabor's post is at: https://perlmaven.com/here-documents

Comment 4

[Dylan Hardison [:dylan] (he/him)]

(In reply to Emma Humphries ☕️ (she/her) [:emceeaich] (UTC-8) +needinfo me from comment #2)
> Created attachment 8887699 [details] [review]
> GitHub pull request
> 
> I was not sure what to do with the heredoc style. 
> 
> Gabor Szabo suggests using q or qq when you need to wrap a heredoc in a
> conditional, but it feels like overkill.

if we had a recent perl, we could just indent it. Oh well.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Given that the last mass-close of intermittents closed some of our Marionette bugs inappropriately I wonder if there will be an announcement whenever such an action is happening. Also I would love to be able to see a query link for Bugzilla I could use to quickly skim all the closed intermittent bugs in my owned areas.

Comment 6

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> Given that the last mass-close of intermittents closed some of our
> Marionette bugs inappropriately I wonder if there will be an announcement
> whenever such an action is happening. Also I would love to be able to see a
> query link for Bugzilla I could use to quickly skim all the closed
> intermittent bugs in my owned areas.

Henrik, this has been discussed on dev-platform. If there are Marionette bugs filed as intermittents which should not be closed, please add the 'leave-open' keyword so that they will be ignored.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Emma Humphries ☕️ (she/her) [:emceeaich] (UTC+2, on PTO until 8-18) +needinfo me from comment #6)
> Henrik, this has been discussed on dev-platform. If there are Marionette
> bugs filed as intermittents which should not be closed, please add the
> 'leave-open' keyword so that they will be ignored.

I'm not going myself through the list of open intermittent bugs which have previously skipped by Joel or Geoff, because those whether depend on a fix on another bug, or have still not been investigated.

I don't see the script in use here and cannot say if that has been taken into account, but I consider it very bad to close those bugs silently as incomplete while work still has to be done.

I'm sure that there are also other situations when such bugs should not be closed. So it would be good to see the conditions on which the script operates on. Emma, if this part has been discussed in dev-platform can you please reference the thread here?

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

here is the dev.platform discussion:
https://groups.google.com/forum/#!searchin/mozilla.dev.platform/intermittent%7Csort:date/mozilla.dev.platform/RVs1FkBC5U4/UByZCaoUBgAJ

I don't know where the script is, or if we have ran it- given that Emma is on PTO for the next 2 weeks, I suspect :dylan might have a better idea of the latest status of this script.

Comment 9

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Henrik, the bugs to be closed are in https://mzl.la/2szfdLn. I need a BMO admin to run the script and I'm waiting on it to be run.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks, but I still would really like to know the following:

1) Do we take temporarily skipped tests into account? If no, how should we mark those?
2) What if bugs like bug 1377359 depends on a fix in the product and the test got a workaround for now to be able to continue it running? I don't want bugs like that closed by this script.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

temporarily skipped bugs should have leave-open in the keywords, likewise if there is a bug that has a temporary hack in place, I assume that has a leave-open as well (given that code had to land and we have the bug in an open state)

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Joel Maher ( :jmaher) (UTC-9) from comment #11)
> temporarily skipped bugs should have leave-open in the keywords, likewise if
> there is a bug that has a temporary hack in place, I assume that has a
> leave-open as well (given that code had to land and we have the bug in an
> open state)

We never did that for Marionette tests also because I wasn't aware of that. I just set the version flag to disabled for the appropriate branch. Also not sure how other components are managed, and how many bugs would fall through. 

Maybe I should go through the list of our Marionette intermittent bugs and mark them appropriately, which is a pain to do actually. :/

Comment 13

[Dylan Hardison [:dylan] (he/him)]

Not sure what I can add to this, except that perhaps we should be limiting this to more specific products?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I think that I updated all of our bugs in the Marionette component to reflect the leave-open state in case of workarounds or disabled tests. So from this perspective we should be fine, and I will continue to watch correct usage of this keyword.