Closed Bug 1381623 Opened 3 years ago Closed 2 years ago

Repurpose the HomePanel context menu for the new Photon menu

Categories

(Firefox for iOS :: Menu and Toolbar, enhancement, P1)

Other
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.30
Tracking Status
fxios 10.0 ---

People

(Reporter: farhan, Assigned: farhan)

References

Details

(Whiteboard: [MobileCore][Photon])

Attachments

(1 file, 1 obsolete file)

55 bytes, text/x-github-pull-request
jhugman
: feedback+
Details | Review
The context menu used on the home panels can be reused for the main menu. Unlike the context menu this menu should appear at the bottom and be a fixed height which is scrollable. 

This menu should be able to land behind a feature flag. Initially, this menu should contain everything in the current menu but later we will probably split things up in order to make the menu more digestible. 


There will be 3 different states for this menu
HomePanel context menu
toolbar menu opened from the bottom toolbar. 
modal popover opened from the top toolbar on iPad
Summary: Repurpose the ActionOverlayTableView context menu for the new Photon menu → Repurpose the HomePanel context menu for the new Photon menu
Whiteboard: [MobileCore][Photon]
Attached file Pull Request (obsolete) —
Attachment #8888088 - Flags: review?(jhugman)
Assignee: nobody → fpatel
Iteration: --- → 1.28
Priority: -- → P1
Attachment #8888088 - Flags: review?(jhugman)
Attached file Pull Request
Attachment #8888088 - Attachment is obsolete: true
Attachment #8900516 - Flags: review?(jhugman)
Iteration: 1.28 → 1.29
Iteration: 1.29 → ---
Priority: P1 → P2
Attachment #8900516 - Flags: review?(jhugman) → feedback+
master https://github.com/mozilla-mobile/firefox-ios/commit/4bccab52688b923457d7d77a4b6d9185d8e9cef4
Status: NEW → RESOLVED
Iteration: --- → 1.30
Closed: 2 years ago
Priority: P2 → P1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.